-
Notifications
You must be signed in to change notification settings - Fork 13
[Notebook] Tutorial - Folium Mapping #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
| @@ -0,0 +1,1613 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #5. import plotutils as putils
issue: currently this is not included alongside and will error on import.
I might suggest that if this is meant to be an exploration of folium in general with VEDA, that you not rely on it and instead pull relevant sections that demonstrate how to use folium along side VEDA into the notebook (will be longer but expose users to the functions if they would like to modify)
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tylanderson plotutils is a notebook organization tactic that @freitagb has already approved for prior notebooks built to support Data Stories. Would plotutils not be able to be used in tutorial notebooks as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did see that 2024 tornadoes notebook uses plotutils, as a sidecar, however that is not in the same folder as this notebook or installed as a package, so the immediate issue is that the import will not resolve and this first cell will error
| @@ -0,0 +1,1613 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #8. items = list(results.items())
suggestion: You could change this to get the first item if that's all that's needed with next(results.items(), None)
Reply via ReviewNB
Description
This notebook shows a tutorial on how to use Folium to create an interactive mapping experience similar to the VEDA environment.
What type of example is this?
Tutorial
Checklist
The following checklist ensures that our notebooks are internally consistent (read more)
<collection_id>.ipynb