Skip to content

Conversation

@acblackford
Copy link
Contributor

Description

This notebook shows datasets utilized in the blizzards data story.

What type of example is this?

Data Story

Checklist

The following checklist ensures that our notebooks are internally consistent (read more)

  • The first cell contains the rendering information with author and data
  • The notebook has a Run this Notebook section (with filename in link)
  • The notebook has an Approach section
  • All the packages that are imported in the notebooks are used within the notebook
  • Any complex geometries are accessed from remote storage
  • Each code cell comes after a markdown cell containing explantory text
  • All cells in the notebook book have been run in order with a fresh kernel (cell numbers should be 1, 2, 3, 4, ...)
  • If the example type is Dataset the filename is <collection_id>.ipynb

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@acblackford
Copy link
Contributor Author

Yet To Do:

  1. Custom colormap from STAC (RSI Snowfall Map)
  2. GOES 3-Band Raster - pull from AWS instead of the VEDA STAC file?

@acblackford
Copy link
Contributor Author

8-28 Update:

  1. GOES Imagery added - still need to remove colorbar from visualization pane
  2. Snowfall accumulation cmap changed to cagegorical option but still needs edited pending updated functions in plot_utils via the tornadoes notebook PR.

@kyle-lesinger

@smk0033
Copy link
Collaborator

smk0033 commented Dec 3, 2025

Hey @acblackford! If this is ready for review, would you mind hitting the "Ready for review" button under "Review required"?

@acblackford acblackford marked this pull request as ready for review December 3, 2025 18:57
@acblackford
Copy link
Contributor Author

@smk0033 This is ready for review! The only thing that needs a small update is the color mapping of the snowfall accumulation data.

@@ -0,0 +1,6442 @@
{
Copy link
Collaborator

@smk0033 smk0033 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be in Markdown, I'd update this to a "Raw" cell and adjust the formatting to the following:

---
title: When Winter Rages
description: Exploring the Power and Impact of Blizzards
author: Andrew Blackford (UAH)
date: August 7, 2025
execute:
   freeze: true
------

Also, make sure to add this notebook to the _quarto.yml file in this PR, that way it'll be visible in the docs site :)


Reply via ReviewNB

@@ -0,0 +1,6442 @@
{
Copy link
Collaborator

@smk0033 smk0033 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #5.        f"{RASTER_API_URL.rstrip('/')}/collections/{collection_id}"

Remove .strip('/') 


Reply via ReviewNB

@@ -0,0 +1,6442 @@
{
Copy link
Collaborator

@smk0033 smk0033 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend splitting this cell up, you might could add the mapping to a new cell like you did with the other examples here


Reply via ReviewNB

@@ -0,0 +1,6442 @@
{
Copy link
Collaborator

@smk0033 smk0033 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #25.        f"{RASTER_API_URL.rstrip('/')}/collections/{collection_id}"

Remove .rstrip('/') 


Reply via ReviewNB

@smk0033
Copy link
Collaborator

smk0033 commented Dec 5, 2025

Great notebook! I've taken a first pass at a review, mostly just cleanup type things. Let me know if you have any questions, mainly about the error I'm getting with some of the utility function arguments

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

PR Preview Action v1.6.3

🚀 View preview at
https://NASA-IMPACT.github.io/veda-docs/pr-preview/pr-246/

Built to branch gh-pages at 2025-12-09 20:34 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@smk0033 smk0033 self-requested a review December 10, 2025 16:56
Copy link
Collaborator

@smk0033 smk0033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback, Andrew! A couple lingering comments, but not blockers or anything major, so I'll approve the PR:

  • Under the section "Example: Total Snowfall (1950 Blizzard)", I'd recommend moving those imports to the top of the notebook with the others
  • I'd recommend removing "rstrip" from a few of the lines. However, the code still works with or without it, so not too concerned here!
  • Recommend splitting up a couple cells that include collection, tile request, and mapping in one. I'd just split the mapping out into it's own cell. This is noted more just for consistency, since some cells are split up and others aren't
  • Unless I'm overlooking something, it seems like everything is pulled from the VEDA STAC, so I think the earthaccess library import at the top can safely be removed

Great notebook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants