parse semantic DLL version in Advisor Lua script #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to not show the advisor message if only the patch level is higher than expected. For example: - expected version: 1.2.0 - installed version: 1.2.3 This allows to release patches for the DLL without necessarily having to publish a new Lua script at the same time. (Regardless, the Lua script should be updated with the following proper NAM release to ensure DLL versions without the patch are rejected, from then on.) (Also increments the expected DLL version to 1.2.3.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to not show the advisor message if only the patch level is higher than expected. For example:
This allows to release patches for the DLL without necessarily having to publish a new Lua script at the same time. (Regardless, the Lua script should be updated with the following proper NAM release to ensure DLL versions without the patch are rejected, from then on.)
(Also increments the expected DLL version to the latest version 1.2.3.)