Street & Sam Revisions v50 #528
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I've pushed a commit I had lying around for a while, resolving the Diag STR x Diag Street issue. The problem wasn't the crossing, but the fact that there were two different IDs for Diagonal STR that were used in roughly equal amounts across the repository. I've replaced all uses of 0x5d500100 by 0x5d302000, but I'm not sure which one is the "correct" one. It wouldn't be hard to do a find-and-replace to switch to the other, though. |
Member
|
0x5d302000 was the old RAM-era STR IID, whereas 0x5d500100 is the RRW-era IID. |
memo33
force-pushed
the
street-sam-revisions-v50
branch
from
1054858 to
a7e5f13
Compare
Collaborator
|
I've force-pushed, removing the last 2 commits, in favor of #535. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for remaining street and SAM issues needing work
Longer-term work:
Need to add an additional tile back into the street INRULs to allow for both the wide-radius curbed and sharp-cornered DxD piece to coexist such that tight configurations such as these are supported.
https://discord.com/channels/383313438065033228/1380951135984292022/1380951141046812764