[TASK] Allow PHPStan to use unlimited processes#1550
Conversation
oliverklee
added
the
developer-specific
oliverklee
force-pushed
the
task/phpstan-processes
branch
from
bf10442 to
99a0bf3
Compare
This helps speed up local development and CI.
oliverklee
force-pushed
the
task/phpstan-processes
branch
from
99a0bf3 to
32368db
Compare
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
I had noticed the PHPStan step taking a short while after making code changes, but does this really speed it up? On a quad-core CPU, I wouldn't expect increasing maximumNumberOfProcesses beyond 4 to make any significant difference.
Yes, on my machine it does. (I have a fat desktop machine with 16 cores, though.) 💪 |
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
Yes, on my machine it does. (I have a fat desktop machine with 16 cores, though.) 💪
Blimey. I didn't know such a beast was possible.
I don't think this change is going to impact the CI servers - they have to complete the job eventually - either now or later - and I don't expect they have another purpose such as hosting websites which could be compromised. I think this setting is intended for dedicated server or VPS environments where the server is also providing website hosting.
2 participants
This helps speed up local development and CI.