Skip to content

Comments

[TASK] Implement CSSNamespace::getArrayRepresentation()#1544

Merged
JakeQZ merged 2 commits intomainfrom
task/array-rep/css-namespace
Feb 22, 2026
Merged

[TASK] Implement CSSNamespace::getArrayRepresentation()#1544
JakeQZ merged 2 commits intomainfrom
task/array-rep/css-namespace

Conversation

@oliverklee
Copy link
Collaborator

Part of #1440.

@oliverklee oliverklee requested a review from JakeQZ February 22, 2026 10:19
@oliverklee oliverklee self-assigned this Feb 22, 2026
@oliverklee oliverklee added testing PRs/issues adding additional tests only, or primarily testing-focused developer-specific Issues that only affect maintainers, contributors, and people submitting PRs labels Feb 22, 2026
@oliverklee oliverklee force-pushed the task/array-rep/css-namespace branch from 641e391 to 4651d89 Compare February 22, 2026 10:21
@coveralls
Copy link

coveralls commented Feb 22, 2026

Coverage Status

coverage: 72.409% (+0.03%) from 72.384%
when pulling ab1e34b on task/array-rep/css-namespace
into 5937304 on main.

throw new \BadMethodCallException('`getArrayRepresentation` is not yet implemented for `' . self::class . '`');
return [
'class' => $this->getShortClassName(),
'url' => $this->url->getArrayRepresentation(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be uri to match the spec?

@oliverklee oliverklee force-pushed the task/array-rep/css-namespace branch from 4651d89 to ab1e34b Compare February 22, 2026 15:13
@oliverklee oliverklee requested a review from JakeQZ February 22, 2026 15:13
@JakeQZ JakeQZ merged commit 7f85aa8 into main Feb 22, 2026
24 checks passed
@JakeQZ JakeQZ deleted the task/array-rep/css-namespace branch February 22, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer-specific Issues that only affect maintainers, contributors, and people submitting PRs testing PRs/issues adding additional tests only, or primarily testing-focused

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants