Skip to content

[TASK] Use getArrayRepresentation() in ValueTest #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JakeQZ merged 1 commit into from
Jan 4, 2026
Merged

[TASK] Use getArrayRepresentation() in ValueTest #1441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions tests/Unit/Value/ValueTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,42 @@ public function parsesArithmeticInFunctions(string $operator): void
self::DEFAULT_DELIMITERS
);

self::assertInstanceOf(CSSFunction::class, $subject);
self::assertSame('max(300px,50vh ' . $operator . ' 10px)', $subject->render(OutputFormat::createCompact()));
$result = $subject->getArrayRepresentation();
self::assertSame(
[
'class' => 'CSSFunction',
'components' => [
[
'class' => 'Size',
'number' => 300.0,
'unit' => 'px',
],
[
'class' => 'RuleValueList',
'components' => [
[
'class' => 'Size',
'number' => 50.0,
'unit' => 'vh',
],
[
'class' => 'string',
'value' => $operator,
],
[
'class' => 'Size',
'number' => 10.0,
'unit' => 'px',
],
],
'separator' => ' ',
],
],
'separator' => ',',
'name' => 'max',
Copy link
Collaborator Author

@JakeQZ JakeQZ Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using assertSame() means the array keys must be in matching order, though it seems slightly illogical for name to be last.

Copy link
Collaborator

@oliverklee oliverklee Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use assertEqualsCanonicalizing instead so we can have the array elements in a more readable order in the test.

Copy link
Collaborator

@oliverklee oliverklee Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I take taht back. We'd want something like assertSameCanonicalizing (as we want to do a strict comparison), which does not exist.

Copy link
Collaborator Author

@JakeQZ JakeQZ Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I take taht back. We'd want something like assertSameCanonicalizing (as we want to do a strict comparison), which does not exist.

That would be nice to have. Also, assertEqualsCanonicalizing sorts the array by value, whereas we want it sorted by key to be canonical. I've thought of a way to get CSSFunction to return the array in a more logical order without significant overhead or duplication, which I'll submit as a separate PR if it works...

Copy link
Collaborator Author

@JakeQZ JakeQZ Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, this particular test is somewhat convoluted. Other simpler tests may not need to worry about the order of the array keys.

Copy link
Collaborator Author

@JakeQZ JakeQZ Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've thought of a way to get CSSFunction to return the array in a more logical order without significant overhead or duplication, which I'll submit as a separate PR if it works...

#1461

],
$result
);
}

/**
Expand Down