Draft
Conversation
oliverklee
added
the
deprecation
oliverklee
added this to the
8.8.0: Deprecate and replace some APIs, and a few fixes milestone
JakeQZ
reviewed
Mar 18, 2025
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
Some of the classes don't have equivalent alternative getters, so we should add these first.
I've made a suggestion for the deprecation note for the interface.
src/CSSList/AtRuleBlockList.php
Outdated
| /** | ||
| * @return string | ||
| * | ||
| * @deprecated since V8.8.0, will be removed in version 9.0.0. Use the specific getter instead. |
Collaborator
There was a problem hiding this comment.
This class doesn't have a specific getter for $arguments, so one will need to be added first.
src/Property/Charset.php
Outdated
| /** | ||
| * @return string | ||
| * | ||
| * @deprecated since V8.8.0, will be removed in version 9.0.0. Use the specific getter instead. |
Collaborator
There was a problem hiding this comment.
This doesn't have a getter for the CSSString object property, only one that returns a native string. I wonder if we should first add a getter for the CSSString.
src/RuleSet/AtRuleSet.php
Outdated
| /** | ||
| * @return string | ||
| * | ||
| * @deprecated since V8.8.0, will be removed in version 9.0.0. Use the specific getter instead. |
Collaborator
There was a problem hiding this comment.
This doesn't have a specific getter for the $arguments property, so we should add one first.
oliverklee
modified the milestones:
8.8.0: Deprecate and replace some APIs, and a few fixes,
V8.9.0: Deprecations and bug fixes
oliverklee
force-pushed
the
task/deprecate/atruleargs
branch
3 times, most recently
from
749bbb7 to
1ade62f
Compare
oliverklee
force-pushed
the
task/deprecate/atruleargs
branch
from
1ade62f to
5517093
Compare
These methods - are not used internally - are redundant to the existing getters - have wildly different return types across classes, which reduces the usefulness of the general method
oliverklee
force-pushed
the
task/deprecate/atruleargs
branch
from
5517093 to
aefa0d4
Compare
oliverklee
modified the milestones:
8.9.0: Deprecations and bug fixes,
9.0.0: Drop support for PHP < 7.2 and clean up things
oliverklee
modified the milestones:
9.1.0: Add support for PHP 8.5,
9.2.0: New features, bug fixes and deprecations
oliverklee
modified the milestones:
9.2.0: New features, bug fixes and deprecations,
9.3.0: New features, bug fixes and deprecations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods