Support for inserting an item in a CSSList#115
Closed
FMCorz wants to merge 1 commit intoMyIntervals:mainfrom
Closed
Support for inserting an item in a CSSList#115FMCorz wants to merge 1 commit intoMyIntervals:mainfrom
FMCorz wants to merge 1 commit intoMyIntervals:mainfrom
Conversation
FMCorz
pushed a commit
to FMCorz/moodle
that referenced
this pull request
Aug 3, 2016
danpoltawski
pushed a commit
to danpoltawski/moodle
that referenced
this pull request
Sep 23, 2016
REMOVE ME ONCE MyIntervals/PHP-CSS-Parser#115 is merged Part of MDL-55071
Chocolate-lightning
added a commit
to Chocolate-lightning/moodle
that referenced
this pull request
Jun 20, 2019
Patch taken from MyIntervals/PHP-CSS-Parser#115 as specified in moodle_readme.txt
Contributor
|
I like the idea, but the method name public function insert($oItem, $oSibling, $sPosition = 'before') {
$iIndex = array_search($oSibling, $this->aContents);
if ($iIndex === false) {
return $this->append($oItem);
} else if ($sPosition === 'before') {
$this->replace($oItem, array($oSibling, $oItem));
} else {
$this->replace($oItem, array($oItem, $oSibling));
}
} |
Contributor
|
As there was no progress on this for the last five years I created #545. |
Contributor
|
@oliverklee I think this can now be closed. |
Collaborator
|
Indeed it can. Thanks for implementing/finishing this, @ziegenberg! ❤️ Implemented in #545. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For your consideration.