Skip to content

Reviewer edits#96

Draft
yemeen wants to merge 59 commits intoJOSS-Paperfrom
reviewer-edits
Draft

Reviewer edits#96
yemeen wants to merge 59 commits intoJOSS-Paperfrom
reviewer-edits

Conversation

@yemeen
Copy link
Member

@yemeen yemeen commented Jan 29, 2026

Pull Request

closes #81 #84

Summary

Description

GRAPH_ECT RESULTS:

fourier_circle_100_complexity_1:
Baseline ECT: 0.0005s ± 0.0001s
Optimized ECT: 0.0003s ± 0.0001s
Baseline/Optimized: 1.77x

fourier_circle_1000_complexity_1:
Baseline ECT: 0.0169s ± 0.0131s
Optimized ECT: 0.0025s ± 0.0007s
Baseline/Optimized: 6.86x

fourier_circle_100_complexity_3:
Baseline ECT: 0.0020s ± 0.0010s
Optimized ECT: 0.0007s ± 0.0004s
Baseline/Optimized: 2.90x

fourier_circle_1000_complexity_3:
Baseline ECT: 0.0100s ± 0.0030s
Optimized ECT: 0.0024s ± 0.0005s
Baseline/Optimized: 4.09x

fourier_circle_10000_complexity_3:
Baseline ECT: 0.0464s ± 0.0152s
Optimized ECT: 0.0123s ± 0.0022s
Baseline/Optimized: 3.78x

fourier_circle_100000_complexity_5:
Baseline ECT: 0.5119s ± 0.1055s
Optimized ECT: 0.1740s ± 0.0128s
Baseline/Optimized: 2.94x

spiral_1000_complexity_2:
Baseline ECT: 0.0100s ± 0.0026s
Optimized ECT: 0.0021s ± 0.0002s
Baseline/Optimized: 4.68x

lemniscate_1000_complexity_3:
Baseline ECT: 0.0054s ± 0.0032s
Optimized ECT: 0.0021s ± 0.0019s
Baseline/Optimized: 2.53x

star_1000_complexity_5:
Baseline ECT: 0.0033s ± 0.0008s
Optimized ECT: 0.0012s ± 0.0002s
Baseline/Optimized: 2.80x

random_walk_1000_complexity_2:
Baseline ECT: 0.0028s ± 0.0008s
Optimized ECT: 0.0012s ± 0.0003s
Baseline/Optimized: 2.40x

spiral_5000_complexity_3:
Baseline ECT: 0.0430s ± 0.0235s
Optimized ECT: 0.0112s ± 0.0026s
Baseline/Optimized: 3.83x

star_5000_complexity_5:
Baseline ECT: 0.0337s ± 0.0279s
Optimized ECT: 0.0076s ± 0.0021s
Baseline/Optimized: 4.42x

CW_ECT RESULTS:

dirs_8_thresh_10:
Baseline ECT: 0.0001s ± 0.0001s
Optimized ECT: 0.0000s ± 0.0000s
Baseline/Optimized: 1.17x

dirs_36_thresh_36:
Baseline ECT: 0.0001s ± 0.0000s
Optimized ECT: 0.0000s ± 0.0000s
Baseline/Optimized: 1.56x

dirs_360_thresh_360:
Baseline ECT: 0.0004s ± 0.0002s
Optimized ECT: 0.0002s ± 0.0001s
Baseline/Optimized: 1.73x

dirs_1024_thresh_1024:
Baseline ECT: 0.0016s ± 0.0007s
Optimized ECT: 0.0012s ± 0.0001s
Baseline/Optimized: 1.31x

Motivation and Context

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvement

Checklist

  • My code follows the code style of this project. (make clean)
  • I have incremented the version number in the pyproject.toml file (if applicable).
  • I have added tests to cover my changes (if applicable).
  • All new and existing tests passed. (make tests)
  • I have updated the documentation (if applicable).
  • My changes generate no new warnings.
  • I have added any necessary new dependencies to pyproject.toml.

Additional Notes

Screenshots (if applicable)

yemeen and others added 30 commits October 1, 2025 13:22
Add documentation and test updates to pull request template
update readme to reflect new changes
yemeen and others added 29 commits January 21, 2026 15:15
…ke a local version of the documentation when testing.
Add test for notebook tutorial execution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments