Make entities appear at world spawn when they go trough exit end portal #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EXtremeExploit
force-pushed
the
should-appear-at-spawn-flag
branch
from
fb2cfbb to
bb3c0d5
Compare
EXtremeExploit
force-pushed
the
should-appear-at-spawn-flag
branch
from
bb3c0d5 to
c630319
Compare
src/main/java/com/onarandombox/MultiverseNetherPortals/listeners/MVNPEntityListener.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Multiverse/Multiverse-Core#2707.
Currently the getLocation on the entity listener was sending the entities on the same location from which the entity crossed the portal from with taking the scaling into account, this is exactly the same behavior it is used for nether portals, however this is not the correct behavior when going from the end to the overworld, since the end portal is mostly always at 0,0 the items will always spawn close to 0,0 in the overworld.
The mean to fix this is by adding a special flag for when the portal is an end portal and the from world is the end, If this flag is true it will teleport specifically to the world's target spawn point