Skip to content

Improve playerdata import error message output #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benwoo1110 merged 1 commit into from
Nov 29, 2025
Merged

Improve playerdata import error message output #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/main/java/org/mvplugins/multiverse/inventories/commands/PlayerDataImportCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,16 +63,16 @@ void onCommand(MVCommandIssuer issuer, World world) {
continue;
}
UUID playerUUID = UUID.fromString(Files.getNameWithoutExtension(playerDataFile.getName()));
Try<ProfileData> profileData = playerDataExtractor.extract(playerDataFile.toPath());
playerDataFutures.add(profileDataSource
.getGlobalProfile(GlobalProfileKey.of(playerUUID))
.thenCompose(profileDataSource::updateGlobalProfile)
.thenCompose(ignore -> profileDataSource.getPlayerProfile(
ProfileKey.of(ContainerType.WORLD, world.getName(), ProfileTypes.getDefault(), playerUUID)))
.thenCompose(playerProfile -> {
playerProfile.update(profileData.get());
return profileDataSource.updatePlayerProfile(playerProfile);
}));
playerDataExtractor.extract(playerDataFile.toPath())
.onSuccess(profileData -> playerDataFutures.add(profileDataSource
.getGlobalProfile(GlobalProfileKey.of(playerUUID))
.thenCompose(profileDataSource::updateGlobalProfile)
.thenCompose(ignore -> profileDataSource.getPlayerProfile(
ProfileKey.of(ContainerType.WORLD, world.getName(), ProfileTypes.getDefault(), playerUUID)))
.thenCompose(playerProfile -> {
playerProfile.update(profileData);
return profileDataSource.updatePlayerProfile(playerProfile);
})));
}
CompletableFuture.allOf(playerDataFutures.toArray(new CompletableFuture[0]))
.thenRun(() -> issuer.sendMessage("Successfully imported all player data from " + world.getName() + "."));
Expand Down
5 changes: 4 additions & 1 deletion src/main/java/org/mvplugins/multiverse/inventories/profile/nbt/PlayerDataExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@ public Try<ProfileData> extract(Path path) {
profileData.set(Sharables.TOTAL_EXPERIENCE, playerData.getInt("XpTotal"));

return profileData;
}).onFailure(Throwable::printStackTrace);
}).onFailure(ex -> {
Logging.warning("Failed to extract player data from %s: %s", path, ex.getMessage());
ex.printStackTrace();
});
}

private ItemStack[] extractItems(@Nullable ListTag<CompoundTag> inventoryList, int dataVersion, int inventorySize) throws IOException {
Expand Down
Loading