PTHMINT-75: Remove unsupported attribute in docs (delivery)#24
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 90.40% 90.42% +0.02%
==========================================
Files 106 106
Lines 2323 2307 -16
==========================================
- Hits 2100 2086 -14
+ Misses 223 221 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielcivit
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes several fields and their associated methods from the
Deliveryclass in thesrc/multisafepay/api/shared/delivery.pyfile, along with corresponding test cases in thetests/multisafepay/unit/api/shared/test_unit_delivery.pyfile. The removed fields includestreet_name,street_name_additional,house_number_suffix, andcountry_name.Changes to the
Deliveryclass:street_name,street_name_additional,house_number_suffix, andcountry_namefrom theDeliveryclass definition. [1] [2]add_street_name,add_street_name_additional,add_house_number_suffix, andadd_country_name).Changes to test cases:
test_initializes_with_valid_valuesandtest_initializes_with_default_valuestests to remove assertions related to the deleted fields. [1] [2] [3]test_adds_street_name,test_adds_street_name_additional, andtest_adds_house_number_suffix.test_creates_from_dict_with_all_fieldsandtest_creates_from_empty_dicttests to remove references to the deleted fields. [1] [2] [3]