PTHMINT-49: Fix ruff B006#20
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses mutable default argument issues and refines configuration settings to improve code safety and maintainability.
- Updates mutable default parameters in ApiException and Decorator classes to use None safely.
- Removes the B006 linting rule from the pyproject.toml configuration to enforce proper default value handling.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/multisafepay/exception/api.py | Changed mutable default argument for context from {} to None without fallback initialization |
| src/multisafepay/api/base/decorator.py | Replaced mutable default for dependencies with a safe initialization using a ternary operator |
| pyproject.toml | Removed lint rule B006 from the ignore list |
| self: "ApiException", | ||
| message: str, | ||
| context: dict = {}, | ||
| context: dict = None, |
There was a problem hiding this comment.
The init method in ApiException should initialize context with an empty dictionary if None is provided, similar to the approach used in the Decorator class.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20 +/- ##
=======================================
Coverage 90.76% 90.76%
=======================================
Files 106 106
Lines 2306 2306
=======================================
Hits 2093 2093
Misses 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to improve code safety and maintainability by addressing mutable default arguments and refining configuration settings. The most important changes include replacing mutable default arguments with
Noneand handling them safely, as well as updating thepyproject.tomlconfiguration to remove an ignored linting rule.Code safety improvements:
src/multisafepay/api/base/decorator.py: Updated the__init__method of theDecoratorclass to replace the mutable default argumentdependencies: Dict = {}withdependencies: Dict = Noneand added logic to initialize it with an empty dictionary ifNoneis provided. [1] [2]src/multisafepay/exception/api.py: Updated the__init__method of theApiExceptionclass to replace the mutable default argumentcontext: dict = {}withcontext: dict = Noneand added logic to initialize it with an empty dictionary ifNoneis provided.Configuration updates:
pyproject.toml: Removed theB006linting rule from theignorelist, which discourages the use of mutable default arguments in function definitions.