[+] Add support for GetGameMusicScoreApi for #47#48
Open
SoulGateKey wants to merge 4 commits intoMuNET-OSS:mainfrom
Open
[+] Add support for GetGameMusicScoreApi for #47#48SoulGateKey wants to merge 4 commits intoMuNET-OSS:mainfrom
SoulGateKey wants to merge 4 commits intoMuNET-OSS:mainfrom
Conversation
Add judgement for GameId and GameVersion
# Conflicts: # AquaMai.Mods/GameSystem/SinglePlayer.cs
更新后的单人游戏入口流程的类图classDiagram
class SinglePlayer {
+PostDecideEntry(EntryMonitor __instance)
+OnAfterPatch()
}
class OperationManager {
+DownloadMusicScore()
}
class GameInfo {
+GameVersion
+GameId
}
SinglePlayer --> OperationManager : calls DownloadMusicScore conditionally
SinglePlayer --> GameInfo : checks GameVersion and GameId
文件级别变更
提示和命令与 Sourcery 交互
自定义您的体验访问您的 仪表板 以:
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideIntroduce conditional invocation of the music score download API in the single‐player entry flow and correct file formatting. Sequence diagram for conditional music score download in single-player entrysequenceDiagram
participant EntryMonitor
participant TimeManager
participant EventManager
participant ScoreRankingManager
participant OperationManager
participant GameInfo
participant SharedInstances
participant Process
participant ProcessManager
EntryMonitor->>TimeManager: MarkGameStartTime()
EntryMonitor->>EventManager: UpdateEvent()
EntryMonitor->>ScoreRankingManager: UpdateData()
EntryMonitor->>GameInfo: Check GameVersion and GameId
alt GameVersion >= 25000 and GameId == "SDEZ"
EntryMonitor->>OperationManager: DownloadMusicScore()
end
EntryMonitor->>SharedInstances: StartCoroutine(LaterDisableCardReader())
EntryMonitor->>Process: CreateDownloadProcess()
EntryMonitor->>ProcessManager: SendMessage(CommonProcess, 30001)
Class diagram for updated SinglePlayer entry flowclassDiagram
class SinglePlayer {
+PostDecideEntry(EntryMonitor __instance)
+OnAfterPatch()
}
class OperationManager {
+DownloadMusicScore()
}
class GameInfo {
+GameVersion
+GameId
}
SinglePlayer --> OperationManager : calls DownloadMusicScore conditionally
SinglePlayer --> GameInfo : checks GameVersion and GameId
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
嘿 @SoulGateKey - 我已经审查了你的修改,它们看起来很棒!
帮助我更有用!请在每个评论上点击 👍 或 👎,我将使用反馈来改进您的评论。
Original comment in English
Hey @SoulGateKey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
clansty
reviewed
Aug 10, 2025
| TimeManager.MarkGameStartTime(); | ||
| Singleton<EventManager>.Instance.UpdateEvent(); | ||
| Singleton<ScoreRankingManager>.Instance.UpdateData(); | ||
| if(GameInfo.GameVersion >= 25000 && GameInfo.GameId == "SDEZ") {Singleton<OperationManager>.Instance.DownloadMusicScore();} |
Author
There was a problem hiding this comment.
已在1.55测试,musicscore可以正常触发下载
以及25000不是1.50吗
Author
There was a problem hiding this comment.
如果版本低于25000(1.50)并且不是sdez的话 不会启用
这个api随着kaleidxscope的加入而加入
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sourcery 总结
新特性:
Original summary in English
Summary by Sourcery
New Features: