Fix styling bleed from NNCheckboxes to other PCF#179
Open
DerekHAu wants to merge 2 commits intoMscrmTools:masterfrom
Open
Fix styling bleed from NNCheckboxes to other PCF#179DerekHAu wants to merge 2 commits intoMscrmTools:masterfrom
DerekHAu wants to merge 2 commits intoMscrmTools:masterfrom
Conversation
Commented text-decoration: line-through as it is impacting other PCF that have checkboxes on the same form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comments out two classes that have been impacting another PCF and don't seem to be in use by the NNCheckbox control any longer (and were in the original CSS committed 5+ years ago).
Per image below, the styles were impacting another PCF (in yellow) but were not applied to the NNCheckbox control. I have applied these changes in our environment successfully.
I haven't done any updates to version numbers or rebuilt the control.