Ported the majority of UIs to NUI #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…game-screen Convert remaining MainGameScreen visuals to NUI
…screen Convert the in-game menu to NUI
…screen Convert the talk screen to NUI
…creen Convert `MapScreen` and `WaypointCreationScreen` to NUI
…ial-screen Convert `TutorialScreen` to NUI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request converts the majority of UI interfaces over to use NUI. There are still a few things still using the previous UI classes where equivalent functionality is not present in NUI.
This is an aggregation of several pull requests which individually port over each screen:
MapScreenandWaypointCreationScreento NUI #669TutorialScreento NUI #670This also brings-back the ability charges bar, which was broken in
2.0.0.You can view a visual comparison of the changes here.
Testing
See the individual PRs for testing information for each screen.
Potential Future Improvements
UIWarnDrawernotifications are not the most visually pleasant. Better placement and design is needed but for now I've tried to retain most lf the original appearance and behaviour.UIWarnDrawernotifications start from the middle of the screen on Android, which shouldn't really be the case.Breaking Changes
GameScreens#mainGameScreenvariable has been re-named toGameScreens#oldMainGameScreen.GameScreens#mainGameScreennow points to the NUI version ofMainGameScreeninstead.Notes