Skip to content

refactoring for issue #164 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Morcules merged 2 commits into from
Jan 16, 2026
Merged

refactoring for issue #164 #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e005b0
refactoring for issue #164
gab-dev-7 Jan 16, 2026
7374611
Added a define for readability, changed type of debug flags from uint…
Morcules Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/add_debug_flags.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#include "swift_net.h"
#include "internal/internal.h"
#include "swift_net.h"

void swiftnet_add_debug_flags(const uint32_t flags) {
debugger.flags |= flags;
void swiftnet_add_debug_flags(const enum SwiftNetDebugFlags flags) {
debugger.flags |= flags;
}
void swiftnet_remove_debug_flags(const uint32_t flags) {
debugger.flags &= ~flags;
void swiftnet_remove_debug_flags(const enum SwiftNetDebugFlags flags) {
debugger.flags &= ~flags;
}
2 changes: 1 addition & 1 deletion src/internal/internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ extern void* check_existing_listener(const char* interface_name, void* const con
#ifdef SWIFT_NET_DEBUG
extern struct SwiftNetDebugger debugger;

static inline bool check_debug_flag(enum SwiftNetDebugFlags flag) {
static inline bool check_debug_flag(const enum SwiftNetDebugFlags flag) {
return (debugger.flags & flag) != 0;
}

Expand Down
17 changes: 10 additions & 7 deletions src/swift_net.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,17 @@ extern uint32_t maximum_transmission_unit;

#ifdef SWIFT_NET_DEBUG
enum SwiftNetDebugFlags {
PACKETS_SENDING = 1u << 0,
PACKETS_RECEIVING = 1u << 1,
INITIALIZATION = 1u << 2,
LOST_PACKETS = 1u << 3
PACKETS_SENDING = 1u << 1,
PACKETS_RECEIVING = 1u << 2,
INITIALIZATION = 1u << 3,
LOST_PACKETS = 1u << 4
};

#define SWIFTNET_DEBUG_FLAGS(num) \
((enum SwiftNetDebugFlags)(num))

struct SwiftNetDebugger {
uint32_t flags;
int flags;
};
#endif

Expand Down Expand Up @@ -396,9 +399,9 @@ extern void swiftnet_server_make_response(

#ifdef SWIFT_NET_DEBUG
// Adds one or more debug flags to the global debugger state.
extern void swiftnet_add_debug_flags(const uint32_t flags);
extern void swiftnet_add_debug_flags(const enum SwiftNetDebugFlags flags);
// Removes one or more debug flags from the global debugger state.
extern void swiftnet_remove_debug_flags(const uint32_t flags);
extern void swiftnet_remove_debug_flags(const enum SwiftNetDebugFlags flags);
#endif


Expand Down
Binary file modified tests/integration_tests/output/run_tests
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion tests/integration_tests/src/run_tests.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ int main() {

swiftnet_initialize();

swiftnet_add_debug_flags(INITIALIZATION | LOST_PACKETS | PACKETS_RECEIVING | PACKETS_SENDING);
swiftnet_add_debug_flags(SWIFTNET_DEBUG_FLAGS(PACKETS_SENDING | PACKETS_RECEIVING | INITIALIZATION | LOST_PACKETS));

for (uint16_t i = 0; i < sizeof(tests) / sizeof(struct Test); i++) {
const struct Test* current_test = &tests[i];
Expand Down
Binary file modified tests/performance_tests/output/run_tests
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion tests/performance_tests/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ void send_large_packets(const bool loopback) {
int main() {
swiftnet_initialize();

swiftnet_add_debug_flags(PACKETS_SENDING | PACKETS_RECEIVING | INITIALIZATION | LOST_PACKETS);
swiftnet_add_debug_flags(SWIFTNET_DEBUG_FLAGS(PACKETS_SENDING | PACKETS_RECEIVING | INITIALIZATION | LOST_PACKETS));

send_large_packets(false);

Expand Down