Skip to content

Conversation

@gab-dev-7
Copy link
Contributor

Updated debug flag signatures to use the SwiftNetDebugFlags enum instead of a raw uint32_t.

  • Updated swift_net.h and add_debug_flags.c signatures.

  • Added necessary casts in the integration and perf tests to keep the compiler happy when ORing flags.

Testing: Built via ./build/build_for_testing.sh and ran integration tests under sudo. Everything passed with no leaks.

Fixes #164

@Morcules
Copy link
Owner

Hello. Thank you for contributing 🚀

This PR only requires changing the type in the debug functions to an enum, there's no need to change 500 LOC or rewrite the entire codebase style.

Please avoid submitting large AI generated slop for simple fixes.

Let me know if you can fix the pr. I will happily merge it.

@Morcules Morcules self-assigned this Jan 16, 2026
@gab-dev-7
Copy link
Contributor Author

Hey, i didn't use AI, just have my tab spacing smaller than yours. That's prob what it is. But I can do it again :)

@Morcules
Copy link
Owner

I mean I can see that you’ve changed even things like tests (new lines inside function agrs, pointer positions), etc.

I would really appreciate it if you did it again, but please don’t create PRs made by AI. It takes a lot of time to respond, correct issues, etc.

@gab-dev-7 gab-dev-7 force-pushed the refactor/debug-flags-enum branch from 1bc6d58 to a596ae7 Compare January 16, 2026 13:21
@Morcules
Copy link
Owner

I can see that it’s AI again. I won’t merge 300 LOC for a thing that requires 5 LOC.

Please contribute to projects that you really understand and don’t just prompt the issue description.

Open source isn’t about creating a pr that takes 5 minutes, adding it to your resume.

AI isn’t as magical as you might think. I don’t need it to change the style of my code base. I don’t need extra comments. I don’t need tabs to be 2 in one file and 4 in another file.

@Morcules Morcules closed this Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change Add debug flags arg type

2 participants