Refactor: Remove sender_address from SwiftNet send_packet API and update header #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you for contributing :) 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the API by not requiring the caller to provide the sender address.
Updates all calls to swiftnet_send_packet to reflect this change.
2.Updated related data structures in headers:
SwiftNetClientAddrData and PacketQueueNode no longer expose a separate sender_address field unnecessarily.
3.Refactored packet processing functions:
process_packets.c and other affected files now construct the sender info internally where required.
Ensures consistent handling of client/server packet metadata.
Note :
process_packets.c checks for private IP addresses when processing packets.
Currently, some private IP checks may not fully handle certain cases, so minor issues could arise in environments with unusual IPs.
This is a pre-existing concern and not caused by these changes, but should be reviewed.