feat(shell): add configurable shell support for Windows#839
Open
HamzaETTH wants to merge 1 commit intoMoonshotAI:mainfrom
Open
feat(shell): add configurable shell support for Windows#839HamzaETTH wants to merge 1 commit intoMoonshotAI:mainfrom
HamzaETTH wants to merge 1 commit intoMoonshotAI:mainfrom
Conversation
Add [shell] configuration section to allow Windows users to use bash
(Git Bash, MSYS2, Cygwin, WSL) instead of being forced to use PowerShell.
Motivation: LLMs tend to generate bash commands (e.g., with &&, ||, export)
that fail in PowerShell. This change allows Windows users to use bash for
better command compatibility with LLM-generated commands.
Changes:
- Add ShellConfig class with 'path' and 'preferred' options
- Implement hybrid shell detection with priority order:
1. Explicit config path
2. SHELL environment variable (only when preferred='auto')
3. Auto-detect based on preferred setting
4. PowerShell fallback (backwards compatible)
- Auto-detect bash from common Windows locations (Git Bash, MSYS2, Cygwin, WSL)
- Treat fish as unknown shell (not bash-compatible)
- Update shell tool to use correct args per shell type
- Log warning when explicit shell path not found
- Add comprehensive tests for shell detection
- Update documentation (EN/ZH)
Backwards compatible: default behavior unchanged (PowerShell on Windows).
Example config:
[shell]
path = "C:/Program Files/Git/bin/bash.exe"
# OR
preferred = "bash" # auto, powershell, bash
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #792
Description
Add [shell] configuration section to allow Windows users to use bash (Git Bash, MSYS2, Cygwin, WSL) instead of being forced to use PowerShell.
Motivation: LLMs tend to generate bash commands (e.g., with &&, ||, export) that fail in PowerShell. This change allows Windows users to use bash for better command compatibility with LLM-generated commands.
Changes:
Backwards compatible: default behavior unchanged (PowerShell on Windows).
Example config:
[shell]
path = "C:/Program Files/Git/bin/bash.exe"
# OR
preferred = "bash" # auto, powershell, bash
Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.