fix: display error message when config.toml has duplicate keys#818
Draft
atulk-code wants to merge 1 commit intoMoonshotAI:mainfrom
Draft
fix: display error message when config.toml has duplicate keys#818atulk-code wants to merge 1 commit intoMoonshotAI:mainfrom
atulk-code wants to merge 1 commit intoMoonshotAI:mainfrom
Conversation
When config.toml contains duplicate keys (e.g., [models.qwen] section defined twice), the CLI would fail silently due to stderr being redirected to the log file during startup. This fix: - Catches ConfigError at the CLI level and displays a user-friendly error message before exiting - Improves the error message to include the config file path - Adds test coverage for duplicate key error handling Fixes MoonshotAI#809
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When config.toml contains duplicate keys (e.g., [models.qwen] section defined twice), the CLI would fail silently due to stderr being redirected to the log file during startup.
This fix:
Fixes #809
Related Issue
Resolve #(issue_number)
Description
Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.