[201_2769] Add accessible property to bibliography drd-props #2850
Open
Gitjay11 wants to merge 1 commit intoMoganLab:mainfrom
Open
[201_2769] Add accessible property to bibliography drd-props #2850Gitjay11 wants to merge 1 commit intoMoganLab:mainfrom
Gitjay11 wants to merge 1 commit intoMoganLab:mainfrom
Conversation
Contributor
Author
|
hii @da-liii @JackYansongLi , When you have time, please review this PR and let me know if any changes are needed, I would be happy to change. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2769
What
Added
accessible|3tobibliographyandaccessible|4tobibliography*in their
drd-propsdefinitions inTeXmacs/packages/section/section-base.tsWhy
Users cannot navigate into the bibliography body using the right arrow key
In TeXmacs, the
accessibleproperty indrd-propscontrols whether cursornavigation via arrow keys can enter a tag's child argument. The
bibliographytag's body is at argument index 3, and
bibliography*'s body is at index 4 —neither had the
accessibleproperty set, so the cursor would skip over them entirely.How
Following the same pattern used by other tags in the codebase (e.g.,
mini-paragraphwith
accessible|1,arrow-with-textwithaccessible|2), so I added theaccessibleproperty pointing to the body argument index in each tag's
drd-propsdeclaration.