fix: add missing import for select and DatasetFiles in replace endpoint#480
Merged
fix: add missing import for select and DatasetFiles in replace endpoint#480
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a runtime NameError in the annotation task API by adding the missing SQLAlchemy/model imports used by the PUT /task/{file_id}/replace endpoint, aligning it with the existing update_file_tags implementation pattern.
Changes:
- Add
selectimport insidereplace_file_tagsto support the query execution. - Add
DatasetFilesimport insidereplace_file_tagsto resolve the referenced ORM model.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix missing import in the newly added
PUT /{file_id}/replaceendpoint.Problem
The endpoint was missing the required imports:
from sqlalchemy.future import selectfrom app.db.models import DatasetFilesThis caused a
NameError: name 'select' is not definedwhen calling the API.Solution
Added the missing imports inside the endpoint function, following the same pattern as the existing
update_file_tagsendpoint.