Conversation
…mproved column widths
…w with enhanced payload handling and UI updates
… with CJK support and metadata detection
…hunk processing logic
…rdless of question generation success
…and improved configuration options
…and improved configuration options
…and improved configuration options
…and improved configuration options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and updates the data synthesis task model and related API/service code to align with a new database schema and configuration approach. The main changes include renaming the main ORM class and table, consolidating configuration fields, updating API endpoints to use the new structure, and improving compatibility with both old and new data formats.
Database Model and Schema Refactor:
DataSynthesisInstancetoDataSynthInstanceand the table fromt_data_synthesis_instancestot_data_synth_instances, updating all references accordingly. The schema now consolidates multiple configuration fields into a singlesynth_configJSON column, removes unused columns, and aligns field names with the new structure.save_synthesis_taskfunction to build and store the newsynth_configstructure, ensuring compatibility with legacy request formats and only saving fields present in the updated table.API and Service Layer Updates:
DataSynthInstanceand the new config structure, including listing, retrieving, creating, and deleting synthesis tasks and related file tasks. This includes extracting fields fromsynth_configwhen constructing response objects for compatibility. [1] [2] [3] [4] [5] [6] [7] [8] [9]DataSynthesisTaskItem) from the newsynth_configfield, ensuring all expected fields are present even if not stored directly in the database. [1] [2]Schema and Type Improvements:
generation.pyschema: replacedSynthesisConfigwithSyntheConfig, introduced a newConfigclass for grouping configs, and changedCreateSynthesisTaskRequestto usesynth_config: Configinstead of separate config fields. [1] [2]Utility and Minor Fixes:
extract_json_substringin evaluation service. [1] [2]These changes modernize the data synthesis task handling, improve maintainability, and ensure forward compatibility with evolving requirements.