Draft
Conversation
Owner
|
Running |
ModProg
requested changes
Jan 5, 2022
Collaborator
Author
|
We will see how the issues I linked above get resolved, but I don't personally have time to do it myself. I consider the linking issue blocking, the issue with weird output when writing can be ignored, the whole writing part can be removed, checking if both are in sync is still useful and works correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure our
READMEand documentation inlib.rsare in sync. I also added aWRITE_README=1environment variable to the test, so we can just update theREADMEinstead of manually syncing them by hand.Remaining issues:
lib.rsthat aren't really necessary.READMEdoesn't produce perfect output, see Write Output zheland/readme-sync#2.