Skip to content

Conversation

@sisby-folk
Copy link
Contributor

@sisby-folk sisby-folk commented Jul 2, 2025

Fixes #18
Fixes #19

Adds:

  • /submission test [submission] for uploading test lot images
  • /submission claim [submission] for uploading claim images
  • /submission build [submission] for uploading booth buildimages
  • /submission update claim [submission] for changing marker and warp coordinates, plus icon
  • /submission update booth [submission] for changing shard count, tourist eta, and completion status

Does this implementation make any sense at all? Who knows!

I figured it best to implement it at any quality level and have it be corrected rather than have the feature potentially slip away - so have at it, feel free to approve as is or change it to suit your preferences (i just might be busy)

@sisby-folk sisby-folk requested a review from TheEpicBlock July 2, 2025 14:23
@sisby-folk
Copy link
Contributor Author

sisby-folk commented Jul 12, 2025

so, I chose args not modals becuase they actually have validated number input, but I think I used too few such that not being able to enter the existing values is a pain.

build edit is fine, but claim edit should be split into map marker (with icon) and warp (without)

same endpoint, just two commands

@Tomate0613
Copy link
Member

Current implementation of the new /submission sub-commands completely break the submission command all together

@sisby-folk sisby-folk changed the title Sloppily implement test/claim/build submission Implement test/claim/build submission Jul 13, 2025
@sisby-folk
Copy link
Contributor Author

sisby-folk commented Jul 13, 2025

Implementation redone, now it's nice. only the first 3 commands exist, and they include the metadata with them.

I use "semi optional" arguments, where I check if platform has the data, and if it doesn't, only putting in some arguments is rejected. That way players will always enter their marker and warp with their claim, but they can edit it one field at a time, AND they get input validation.

working:

Discord_BtFHJJx4M5.mp4

@sisby-folk
Copy link
Contributor Author

Added phase validation:
image

@sisby-folk sisby-folk merged commit 4676b05 into prod Jul 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants