You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When filtering by license, it should display the licenses in an OR method. It should also display a chip with the ability to clear it and have the license in the URL. It should also display the license in the search row
Testing tips:
Go on the feeds search page and play around with license filtering
Design Assumption
I filter / display the license exclusively by their ID as the real name is very long and cluttering. This is done with the assumption that people who will be interested in license data will be familiar with the abbreviations (ex: CC-BY-4.0).
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the unit tests with yarn test to make sure you didn't break anything
Add or update any needed documentation to the repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
Summary:
Adds Licence Search based on the PR in the original repository
https://github.com/MobilityData/mobility-feed-api/pull/1595/changes
Expected behavior:
When filtering by license, it should display the licenses in an OR method. It should also display a chip with the ability to clear it and have the license in the URL. It should also display the license in the search row
Testing tips:
Go on the feeds search page and play around with license filtering
Design Assumption
I filter / display the license exclusively by their ID as the real name is very long and cluttering. This is done with the assumption that people who will be interested in license data will be familiar with the abbreviations (ex: CC-BY-4.0).
Please make sure these boxes are checked before submitting your pull request - thanks!
yarn testto make sure you didn't break anything