Skip to content

Build the pinned MEOS with the CBUFFER, NPOINT, POSE and RGEO modules#145

Open
estebanzimanyi wants to merge 1 commit into
fix/worker-thread-linkage-crashesfrom
feat/meos-extended-type-modules
Open

Build the pinned MEOS with the CBUFFER, NPOINT, POSE and RGEO modules#145
estebanzimanyi wants to merge 1 commit into
fix/worker-thread-linkage-crashesfrom
feat/meos-extended-type-modules

Conversation

@estebanzimanyi
Copy link
Copy Markdown
Member

The MobilityDuck extended temporal type ports (tcbuffer, tnpoint, tpose, trgeometry) cannot link until the vcpkg-built MEOS exposes those modules. MEOS builds them opt-in and RGEO is a dependent option that requires POSE, so all four are enabled together in the vcpkg portfile OPTIONS, leaving each subsequent type port as pure extension code. Stacked on #134 because main's pinned MEOS predates the symbols these modules need and #134 already advances the pin; #134's pin-bump commit shows in the diff until it merges. The OPTIONS edit is independent of the REPO/REF/SHA512 pin lines that #142 and #143 rewrite, so it composes with whichever pin lands and needs only ordering, not textual reconciliation, against those PRs.

@estebanzimanyi
Copy link
Copy Markdown
Member Author

Reviewer's quickstart — ~2 minutes

What this PR does in one sentence: flips the MEOS build flags in vcpkg_ports/meos/portfile.cmake to compile the CBUFFER, NPOINT, POSE, and RGEO extension-type modules into the pinned MEOS.

Files (1): vcpkg_ports/meos/portfile.cmake — single-file change adding -DMEOS_CBUFFER=ON -DMEOS_NPOINT=ON -DMEOS_POSE=ON -DMEOS_RGEO=ON (or equivalent) to the vcpkg CMake invocation.

Unlocks: the feat/*_port_core stack (#148/#150/#151/#153/#155/#156) — each of those PRs registers DuckDB UDFs that need the corresponding MEOS-side modules linked.

Cross-link: stacked on #134 (the base pin bump). Once #134 lands, this rebases on main and the *_port_core PRs can adopt this MEOS.

Why it's safe to merge: pure build-flag change; doesn't alter source code.

estebanzimanyi added a commit to estebanzimanyi/MobilityDuck that referenced this pull request May 25, 2026
Enable the opt-in MEOS modules required to port the extended temporal
types (tcbuffer, tnpoint, tpose, trgeometry) into MobilityDuck. RGEO is
a dependent option that requires POSE. The pinned MEOS now exposes the
tcbuffer_/tnpoint_/tpose_/trgeo_ symbol families; the base type suite
remains green (1727 assertions, 76 cases).

Folds open PR MobilityDB#145.
@estebanzimanyi estebanzimanyi force-pushed the feat/meos-extended-type-modules branch 2 times, most recently from 8cd82d4 to baa3d09 Compare May 27, 2026 00:26
@estebanzimanyi estebanzimanyi force-pushed the feat/meos-extended-type-modules branch 8 times, most recently from 1ac9cc5 to 204ac54 Compare May 29, 2026 22:55
@estebanzimanyi estebanzimanyi changed the base branch from fix/bump-meos-pin to fix/bump-meos-pin-wasm-pgconfig May 30, 2026 06:29
@estebanzimanyi estebanzimanyi changed the base branch from fix/bump-meos-pin-wasm-pgconfig to fix/bump-meos-pin May 30, 2026 07:00
@estebanzimanyi estebanzimanyi force-pushed the fix/bump-meos-pin branch 4 times, most recently from fa2de57 to 17588c0 Compare June 2, 2026 09:47
@estebanzimanyi estebanzimanyi force-pushed the feat/meos-extended-type-modules branch from 204ac54 to bd60aa4 Compare June 2, 2026 13:42
@estebanzimanyi estebanzimanyi changed the base branch from fix/bump-meos-pin to fix/worker-thread-linkage-crashes June 2, 2026 14:04
@estebanzimanyi estebanzimanyi force-pushed the feat/meos-extended-type-modules branch from bd60aa4 to 10be1d0 Compare June 2, 2026 14:04
@estebanzimanyi estebanzimanyi force-pushed the fix/worker-thread-linkage-crashes branch from a33f008 to ec582fe Compare June 5, 2026 16:02
@estebanzimanyi estebanzimanyi force-pushed the feat/meos-extended-type-modules branch from 10be1d0 to 5b24d8e Compare June 5, 2026 16:02
@estebanzimanyi estebanzimanyi force-pushed the fix/worker-thread-linkage-crashes branch from ec582fe to f9e99dc Compare June 5, 2026 17:15
@estebanzimanyi estebanzimanyi force-pushed the feat/meos-extended-type-modules branch from 5b24d8e to 6ede112 Compare June 5, 2026 17:15
@estebanzimanyi estebanzimanyi force-pushed the fix/worker-thread-linkage-crashes branch from f9e99dc to 20328a7 Compare June 5, 2026 18:42
@estebanzimanyi estebanzimanyi force-pushed the feat/meos-extended-type-modules branch from 6ede112 to aff2189 Compare June 5, 2026 18:42
@estebanzimanyi estebanzimanyi force-pushed the fix/worker-thread-linkage-crashes branch from 20328a7 to 6a4edaf Compare June 6, 2026 04:38
@estebanzimanyi estebanzimanyi force-pushed the feat/meos-extended-type-modules branch from aff2189 to a4a6ef0 Compare June 6, 2026 04:38
@estebanzimanyi estebanzimanyi force-pushed the fix/worker-thread-linkage-crashes branch from 6a4edaf to dab415b Compare June 6, 2026 06:10
@estebanzimanyi estebanzimanyi force-pushed the feat/meos-extended-type-modules branch 2 times, most recently from 656919e to 88c6161 Compare June 6, 2026 06:35
@estebanzimanyi estebanzimanyi force-pushed the fix/worker-thread-linkage-crashes branch 2 times, most recently from 22d2966 to db34f35 Compare June 6, 2026 07:15
@estebanzimanyi estebanzimanyi force-pushed the feat/meos-extended-type-modules branch from 88c6161 to 9bf5ef8 Compare June 6, 2026 07:15
@estebanzimanyi estebanzimanyi force-pushed the fix/worker-thread-linkage-crashes branch from db34f35 to a8d5194 Compare June 6, 2026 23:52
@estebanzimanyi estebanzimanyi force-pushed the feat/meos-extended-type-modules branch from 9bf5ef8 to 458c711 Compare June 6, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant