Skip to content

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Nov 19, 2025

Change Summary

Now Iceberg connection has 2 connection_data schemas - one with S3 URL and params (direct S3 access), another with no S3 params at all (access is delegated to REST Catalog). This makes schema a bit complex for UI to implement, but allows to avoid copy-pasting the entire Iceberg connection logic into new connection class.

Based on MobileTeleSystems/onetl#413.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Nov 19, 2025
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

Coverage

Coverage Report •
FileStmtsMissCoverMissing
syncmaster/dto
   connections.py178597%146, 153–155, 161
   transfers.py112199%93
syncmaster/schemas/v1/connections
   iceberg.py46197%82
syncmaster/worker
   controller.py93198%257
   spark.py79297%132–133
syncmaster/worker/handlers/db
   iceberg.py54492%59, 99, 119, 135
TOTAL509229694% 

@dolfinus dolfinus merged commit 3f3d8f9 into develop Nov 21, 2025
24 of 25 checks passed
@dolfinus dolfinus deleted the feature/DOP-30631 branch November 21, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants