-
Notifications
You must be signed in to change notification settings - Fork 1
[DOP-29496] Load settings from config.yml #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6a84abd to
be2780c
Compare
be2780c to
84ddd7b
Compare
84ddd7b to
9c2c822
Compare
9c2c822 to
dc17a5b
Compare
dc17a5b to
3e2906c
Compare
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
Author
|
I can split this PR onto 2 - one with |
marashka
approved these changes
Nov 10, 2025
3e2906c to
373a4b8
Compare
TiGrib
reviewed
Nov 10, 2025
|
|
||
| @pytest_asyncio.fixture | ||
| async def mock_keycloak_api(settings): # noqa: F811 | ||
| print(settings) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it for debugging ?
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in develop branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The main way to configure SyncMaster is now
config.yml. It is still possible to set environment variables to override some settings, but it is less secure and cumbersome.From source code perspective not much have changed. Most of changed are related to documentation and to logging config (which can be now configured directly via
config.ymlinstead of passing hardcoded preset name).Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)