Skip to content

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Oct 31, 2025

Change Summary

The main way to configure SyncMaster is now config.yml. It is still possible to set environment variables to override some settings, but it is less secure and cumbersome.

From source code perspective not much have changed. Most of changed are related to documentation and to logging config (which can be now configured directly via config.yml instead of passing hardcoded preset name).

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

Coverage

Coverage Report •
FileStmtsMissCoverMissing
syncmaster/server
   __init__.py40392%75–77
syncmaster/server/scripts
   manage_superusers.py682169%52–54, 72–74, 90–91, 93–95, 97–99, 101–102, 104, 108–109, 111, 113
syncmaster/server/settings/server
   static_files.py14750%33–39
syncmaster/worker
   transfer.py62788%51–52, 83–86, 101
syncmaster/worker/settings
   hwm_store.py18383%65–67
TOTAL503628094% 

@dolfinus dolfinus marked this pull request as ready for review October 31, 2025 11:53
@dolfinus
Copy link
Member Author

I can split this PR onto 2 - one with config.yml, and another one with just logging configuration.

@dolfinus dolfinus merged commit 4bf877d into develop Nov 10, 2025
20 of 23 checks passed
@dolfinus dolfinus deleted the feature/DOP-29496 branch November 10, 2025 11:48

@pytest_asyncio.fixture
async def mock_keycloak_api(settings): # noqa: F811
print(settings)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it for debugging ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants