NetworkPingDisplay: make connection quality readable (Q: STATUS [■■··]) and auto-size bar by enum#4059
Open
tigran-sargsyan-w wants to merge 2 commits intoMirrorNetworking:masterfrom
Conversation
Collaborator
|
If we do this, the EXCELLENT should be shortened to GREAT so it doesn't rattle the UI so much. Alternatively, we could show the "unlit" bars so it would be obvious that there's always max 4 bars and only some are lit with color. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Collaborator
|
looks good, but seems to break on Unity 6 as per CI. could you try it there once please? |
Author
Hi @miwarnec , |
Collaborator
|
@MrGadget1024 up to you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the default NetworkPingDisplay overlay so that connection quality is immediately readable and consistent across enum changes.
Replaces the hard-to-parse “dash count” with:
Q: EXCELLENT [■■■■] / Q: ESTIMATING [····]Motivation

The previous UI showed quality as a growing number of dashes:
Q: ----This is ambiguous for players and non-obvious for developers (how many “-” is GOOD?). Explicit text + a fixed-length bar is a common visual language and improves usability without adding complexity. Especially when we work in Editor
What changed (high level)
int totalSegments = Enum.GetValues(typeof(ConnectionQuality)).Length - 1;Q: {STATUS} [{bar}]and keep RTT as before.Before / After
Before:


After:

