Fix for NetworkBehaviour.authority

[Pelax]

Checking for both isClient and isServer to consider NetworkManagerMode.Host

Currently this flag is returning false if a NB is spawned without an ownerConnection (server-owned) in a host. It evaluates isClient as true and does the clients checks only. But if the NB syncs server-to-client, the host actually has authority.

[miwarnec]

good find.
I'll add a unit test for this later before we merge.
unless you wanna :)

[Pelax]

Yeah I could do that. Would 4 tests that check if it's true work? I'm thinking client only, server only, host as client, host as server.

Also, should it be included in Assets\Mirror\Tests\Editor\NetworkBehaviour\NetworkBehaviourTests.cs, or somewhere else?

[miwarnec]

@Pelax any chance you could explain how to reproduce this with our tanks example?

[Pelax]

@vis2k You can repro it by spawning any server-to-client object without ownerConnection while in host mode, and evaluating the authority.
For the tanks example, it can reproduced using the Projectile class, since they are spawned without an ownerConnection parameter. You could write something like this inside the Start method:

Debug.Log("syncDirection: " + syncDirection);
Debug.Log("authority: " + authority);

Then you start the host, and shoot, the console will indicate that the projectile is server-to-client and authority is false (but as we know authority is true)

[miwarnec]

thanks for explanation, gonna test in a few days!

[miwarnec]

there are two issues here:

1. hasAuthority is false for NPCs #3528
2. NPC SyncDirection .authority is false #3529

[miwarnec]

fixed slightly differently. nice find!
#3529

[Pelax]

@vis2k looks like you did what @MrGadget1024 suggested a few weeks ago. I might be wrong, but as I mentioned in that conversation, I think this only reverses the problem. Wouldn't a client-owned with client-to-server sync direction entity return false in a host now?

[miwarnec]

@vis2k looks like you did what @MrGadget1024 suggested a few weeks ago. I might be wrong, but as I mentioned in that conversation, I think this only reverses the problem. Wouldn't a client-owned with client-to-server sync direction entity return false in a host now?

I reopend the PR: #3531
gonna look into your suggestion asap, thanks

[aletoivonen]

I tested this and for me this works just as I expect it to work based on the documentation.

[Pelax]

@vis2k I added these 8 tests with the variations that make sense to me, let me know what you think. If I run them in master branch, the one at line 174 fails (Host isOwned=false syncDirection=ServerToClient), basically the error that motivated this change suggestion.

[miwarnec]

sorry, totally forgot this.
fixed on master and I still use your tests