Update SPA script README.md#622
Open
OmarAboulMakarem wants to merge 2 commits intoMiniProfiler:masterfrom
Open
Update SPA script README.md#622OmarAboulMakarem wants to merge 2 commits intoMiniProfiler:masterfrom
OmarAboulMakarem wants to merge 2 commits intoMiniProfiler:masterfrom
Conversation
the old script was not working, this script is the one passed to Rails FE and when used in SPA it works
| data-html-container="body" | ||
| data-hidden-custom-fields></script> | ||
| <script | ||
| type="text/javascript" |
Contributor
There was a problem hiding this comment.
The type attribute should be omitted here. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script/type
Author
There was a problem hiding this comment.
thank you for your comment but its the same as in the old script in the readme file and i think if you remove it, it will create the MIME type error in the browsers.
also about the data-ids, when i leave it empty it doesnt work, how can i dynamically catch the correct id and place it in it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the old script was not working, this script is the one passed to Rails FE and when used in SPA it works
sadly the script only works when i get the correct data-ids from the rails admin script, but it changes dynamically, i dont know how to get the new value everytime