Refactor parameter query settings into its own class#592
Refactor parameter query settings into its own class#592technicalpickles wants to merge 17 commits intoMiniProfiler:masterfrom
Conversation
|
This PR kinda got away from me 😁 It ended up being more about abstracting what settings are being passed in via query parameters than the skip logic. I made a QuerySettings which encapsulates the logic. I think this has nice parity with ClientSettings, because we have places that end up like As I was going through this, I saw that there are a bunch of places doing |
nateberkopec
left a comment
There was a problem hiding this comment.
This is a big improvement for readability. 👍
|
Have some merge conflicts to sort out in the wake of #593 |
|
I like this change a lot but yeah we need a rebase here. |
…xing tons of times
8567b70 to
021b8c3
Compare
|
Darn. This may be tricky to merge. I had done something like this years back. Thanks for this PR Josh. (and ✋ ) |
@nateberkopec mentioned in passing how big the
callmethod is. This is just my attempt to reduce it a little 😁