FG Legacy Bulk tests#10
Conversation
|
Java 6 is functional, I did both a fix on mavenizer's end (setting the recompile target to java 6) and a fix on our the user end. |
| // This is required by old Forge versions because Java 8u20 changed the sorting implementation for Lists | ||
| // And that causes a ConcurrentModificationException, this **could** be added by Mavenizer but i'm on the fence for doing that. | ||
| // https://github.com/MinecraftForge/LegacyJavaFixer/blob/master/src/main/java/net/minecraftforge/legacyjavafixer/sort/LegacyJavaSortTweaker.java | ||
| implementation('net.minecraftforge.lex:legacyjavafixer:1.0') |
There was a problem hiding this comment.
Adding LegacyFixer this way doesn't work, possibly because the game launches before it's applied. We can only add it manually to the working directory.
There was a problem hiding this comment.
Ill double check when im back at a computer. I might of added it to my mods folder and forgot while working on other things.
If that is the case. Then it is most likely due to FML not scanning the classpath for tweakers.
Would you happen to know off hand what FML for 1.6.4 DOES scan for tweakers? Im sure itnscans more then just the mods folder as how else would it find in-dev tweakers. Perhaps it just needs an environemt variable of something.
There was a problem hiding this comment.
I don't understand these underlying things, but I can search the FML source code to try to get relevant information.
I even discovered by reading the source code that AccessTransformer in version 1.6.4 is not automatically applied in the runtime environment; a separate Coremod plugin needs to be written to add a class that inherits from AccessTransformer.
There was a problem hiding this comment.
I was able to find it on my phone. need to provide fml.coreMods.load
There was a problem hiding this comment.
It's strange that the JAR file I got from Forge Maven doesn't have this namespace and class, but the reference still works.
EDIT:Actually, there were too many irrelevant error codes, and CNF exceptions were pushed to the top. I misread it.
2 participants
MDKExamples companion to MinecraftForge/MinecraftMavenizer#29
Requires publishing that Pr to your maven local and making sure the build number is correct
Most everything is working, last target is 1.6.4