Skip to content

Change Hash field to SHA256 for package integrity #11252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t-johnson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change Hash field to SHA256 for package integrity #11252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/deployment/packagefiles-element-bootstrapper.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ The `PackageFiles` element contains `PackageFile` elements, which define the ins
| `HomeSite` | Optional. The location of the package on the remote server, if it is not included with the installer. |
| `CopyOnBuild` | Optional. Specifies whether the bootstrapper should copy the package file onto the disk at build time. The default is true. |
| `PublicKey` | The encrypted public key of the package's certificate signer. Required if `HomeSite` is used; otherwise, optional. |
| `Hash` | Optional. An SHA1 hash of the package file. This is used to verify the integrity of the file at install time. If the identical hash cannot be computed from the package file, the package will not be installed. |
| `Hash` | Optional. An SHA256 hash of the package file. This is used to verify the integrity of the file at install time. If the identical hash cannot be computed from the package file, the package will not be installed. (Note this was a SHA1 Hash for .NET 3.5 and earlier) |
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording/terminology is inconsistent with the rest of the deployment docs: use the standard hyphenated forms (e.g., “SHA-256” / “SHA-1”) and lowercase “hash”. Also “An SHA256” is grammatically incorrect; it should be “A SHA-256 …” (or rephrase to avoid the article).

Suggested change
| `Hash` | Optional. An SHA256 hash of the package file. This is used to verify the integrity of the file at install time. If the identical hash cannot be computed from the package file, the package will not be installed. (Note this was a SHA1 Hash for .NET 3.5 and earlier) |
| `Hash` | Optional. A SHA-256 hash of the package file. This is used to verify the integrity of the file at install time. If the identical hash cannot be computed from the package file, the package will not be installed. (Note this was a SHA-1 hash for .NET 3.5 and earlier) |

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parenthetical note “.NET 3.5 and earlier” is ambiguous in this bootstrapper schema context (it’s not clear whether this refers to Visual Studio versions, the bootstrapper engine version, or something else). Consider clarifying which tooling/runtime versions expect SHA-1 vs SHA-256 and (ideally) link to an authoritative reference so readers know when the behavior changed.

Copilot uses AI. Check for mistakes.

## Example
The following code example defines packages for the .NET Framework redistributable package and its dependencies, such as the Windows Installer.
Expand All @@ -70,4 +70,4 @@ The `PackageFiles` element contains `PackageFile` elements, which define the ins
## See also
- [\<Product> element](../deployment/product-element-bootstrapper.md)
- [\<Package> element](../deployment/package-element-bootstrapper.md)
- [Product and package schema reference](../deployment/product-and-package-schema-reference.md)
- [Product and package schema reference](../deployment/product-and-package-schema-reference.md)