Skip to content

Fixing logic issue with Gen5 Diag Eye diagram on CLI #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mspicer wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing logic issue with Gen5 Diag Eye diagram on CLI #362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
562c5a5
Fixing Gen5 Eye Diagram which was only checking for dev pointer and n…
mspicer Jan 23, 2026
310a9bc
Fixing not statement
mspicer Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/diag.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,8 @@ int switchtec_diag_eye_set_mode(struct switchtec_dev *dev,
int switchtec_diag_eye_read(struct switchtec_dev *dev, int lane_id,
int bin, int* num_phases, double* ber_data)
{
if (dev) {
fprintf(stderr, "Eye read not supported on Gen 4 switches.\n");
if (!switchtec_is_gen5(dev)) {
fprintf(stderr, "Gen5 Eye read not supported on Gen 4 switches.\n");
return -1;
}
struct switchtec_gen5_diag_eye_read_in in = {
Expand Down