Respect sign translation fallbacks for Meteor key spoofing#6187
Open
Zitrone30 wants to merge 1 commit intoMeteorDevelopment:masterfrom
Open
Respect sign translation fallbacks for Meteor key spoofing#6187Zitrone30 wants to merge 1 commit intoMeteorDevelopment:masterfrom
Zitrone30 wants to merge 1 commit intoMeteorDevelopment:masterfrom
Conversation
AbstractSignEditScreenMixin was turning Meteor translation keys on signs into the raw key string every time. That broke vanilla behavior for signs that include a fallback, since vanilla returns the fallback when the key can’t be resolved. This keeps the existing key protection, but if the sign text is translatable and includes a fallback, it uses that fallback instead. If there isn’t one, it still uses the raw key. This makes Meteor behave like vanilla for fallback-based sign checks and fixes the detection issue.
Collaborator
|
this hotfix is still flawed as it does not take server resource packs into account in my opinion it is better to outright remove it at this time with #6186 to let dedicated mods such as exploit preventer handle it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
AbstractSignEditScreenMixin was turning Meteor translation keys on signs into the raw key string every time. Which broke vanilla behavior for signs that include a fallback. Vanilla returns the fallback when the key can’t be resolved.
This change keeps the existing key protection. But if the sign text is translatable and includes a fallback, it uses that fallback instead. If there isn’t one, it still uses the raw key. This makes Meteor behave like vanilla for fallback-based sign checks and fixes the detection issue.
How Has This Been Tested?
Gone on a server with a detection and not detected
Checklist: