WIP: Subcommand to list volumes and their paths#111
Open
rlupton20 wants to merge 1 commit intoMetaswitch:mainfrom
Open
WIP: Subcommand to list volumes and their paths#111rlupton20 wants to merge 1 commit intoMetaswitch:mainfrom
rlupton20 wants to merge 1 commit intoMetaswitch:mainfrom
Conversation
Collaborator
Author
|
@bossmc fyi. I will change the interface a bit, but this is a first small step on providing better volume ergonomics. |
Signed-off-by: Richard Lupton <richard.lupton@gmail.com>
Contributor
|
Cool! Some early comments (some of which you may already have done):
This also brings up a question - what cleans up the volumes? The shared ones, probably nothing, that makes sense, but the non-shared ones are invalidated by any change to the floki file right (or maybe it's just the path)? Also - could/should non-shared volumes be docker volumes rather than host volumes? We don't need the "real" nature of the host volume for non-shared ones, we just want persistence (in theory we could have shared-volumes in docker, but there I suspect the ability to share the volume with the host is valuable)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Richard Lupton richard.lupton@gmail.com
Subcommand to provide information on volumes. e.g.