fix: Validate email addresses#4005
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4005 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 427 425 -2
Lines 12408 12370 -38
Branches 1949 1949
=======================================
- Hits 12232 12195 -37
+ Misses 176 175 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
370
to
374
| email.split('@').length === 2, | ||
| `Unable to parse email address "${email}".`, | ||
| ); | ||
|
|
||
| const hostname = email.split('@')[1]; |
Member
There was a problem hiding this comment.
Can we re-use the result of email.split()?
FrederikBolding
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some basic validation for email addresses.
Note
Medium Risk
Updates
validateLinkmailto handling to fail fast on malformed email strings (e.g., multiple@), which may change which links are accepted and how phishing checks are applied.Overview
Tightens
mailto:link validation invalidateLinkby requiring each email recipient to contain exactly one@before extracting the domain for phishing-list checks.Adds a unit test to ensure malformed emails like
mailto:foo@bar.com@baz.comthrow a clear parse error and do not invoke the phishing-list checker.Reviewed by Cursor Bugbot for commit d178d8a. Bugbot is set up for automated code reviews on this repo. Configure here.