build: loosen is-release branch name check #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
approved these changes
Oct 27, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: CI Status Misleading by Job Dependency
The all-jobs-pass job only depends on lint-build-test, allowing it to succeed even if publish-release fails. This results in a misleading CI status, as the workflow can appear successful despite a critical failure.
.github/workflows/main.yml#L47-L48
mobile-wallet-protocol/.github/workflows/main.yml
Lines 47 to 48 in e0fc4e3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosens the
is-releaseCI job branch name checkNote
Removes the commit prefix filter from the is-release GitHub Actions job to relax release detection on push.
is-releasejob: Removewith.commit-starts-with: 'Release [version]'fromMetaMask/action-is-release@v1in.github/workflows/main.yml, loosening release commit detection.Written by Cursor Bugbot for commit e0fc4e3. This will update automatically on new commits. Configure here.