chore: fix outline pill on scroll back token details ac

[sahar-fehri]

Description

Fix advanced chart outline pill when panning / first load.

This updates the TradingView webview script (chartLogic.js) that drives the custom outline price pill (the hollow label on the price axis) so it shows and hides at the right times and doesn’t flicker when you scroll or when the chart first loads.

• Panning to old history (oldest bars on the left)
  You’re looking at old bars; the newest bar is off the right. The outline should show.
  On main, sometimes the geometry still said “the marker would be in the plot” (or didn’t line up with which bars are actually loaded), so the app thought: “dot is still ‘there’, hide the outline.” (when it shouldn't) => cause regression
  So the outline disappeared when it should stay.

What the new code adds (why it fixes that)
isSeriesTailOffScreenByData — Looks at actual OHLCV: “Is the newest bar outside what counts as visible for the bars we have?” If yes, treat the tail as off-screen.
shouldHideVisibleEdgeOutlinePill — Show the outline if either geometry says the dot isn’t in the plot or data says the tail is off-screen (so you don’t rely on only coordinateToTime).

Changelog

CHANGELOG entry: fix showing outline pill on advanced charts on old history when chart head is visible.

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Touches time/price scale math and visibility heuristics for TradingView overlays; bugs could cause the outline/last-close pills to misrender or flicker during pan/zoom and first load.

Overview
Fixes the advanced chart outline price pill so it shows reliably when users pan away from the latest bar and stops disappearing/flickering due to inconsistent time-scale geometry.

The outline pill visibility logic is reworked to combine a new plot-geometry check (isCustomLineEndMarkerVisibleInPlot) with a data-based fallback (isSeriesTailOffScreenByData), plus a more resilient “visible edge” bar selection (getVisibleEdgeOutlineBar). Line charts also now compute the outline price by interpolating the close at the plot’s right edge, and Y-coordinate mapping for pills is updated to support inverted and log price scales.

^{Reviewed by Cursor Bugbot for commit 4d31807. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
11 value mismatches detected (expected — fixture represents an existing user).
View details

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: None (no tests recommended)
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 92%

click to see 🤖 AI reasoning details

E2E Test Selection:
The two changed files (chartLogic.js and chartLogicString.ts) are the source and string-serialized versions of the same WebView-internal JavaScript chart logic for the AdvancedChart component (a TradingView-based OHLCV chart). The changes are:

1. Code quality refactoring: var → const/let throughout
2. New helper functions for improved outline price pill visibility detection (shouldHideVisibleEdgeOutlinePill, isCustomLineEndMarkerVisibleInPlot, isSeriesTailOffScreenByData, getVisibleEdgeOutlineBar, getVisiblePlotRightEdgeTimeMs, interpolateCloseAlongLineAtTimeMs)
3. Improved price Y coordinate calculation with log scale and inverted scale support
4. Better fallback for visible range reading (getVisibleBarsRange → getVisibleRange fallback)
5. Line chart price interpolation for the outline price pill

Investigation confirmed:

• No E2E test files (.e2e., .spec.) reference AdvancedChart, chartLogic, OHLCV, TokenDetails, or AssetOverview
• The AdvancedChart is used only in AssetOverview/Price and TokenDetails views — token detail screens not covered by any E2E test suite
• These changes are entirely contained within WebView-internal JavaScript rendering logic
• No controllers, Engine, navigation, wallet flows, confirmations, or shared infrastructure are affected
• The changes are bug fixes/improvements to chart visual rendering (price pill positioning when panning historical data)

Since no E2E tests cover this component and the changes are isolated to WebView-internal chart rendering logic with no impact on any tested user flows, no E2E test tags need to be run.

Performance Test Selection:
The changes are confined to WebView-internal JavaScript chart rendering logic (price pill positioning, outline visibility, log scale Y coordinate calculation). These are visual rendering improvements within a TradingView WebView and do not affect app-level performance metrics like account list rendering, onboarding, login, swaps, app launch, or asset loading. No performance test tags are warranted.

View GitHub Actions results

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[juanmigdr]

I have tested locally and the PR fixes what is intended to fix. In terms of the math and code changes, I believe it has been developed correctly and trust @sahar-fehri's criteria