Skip to content

chore: clean up pna25 feature flag#28808

Merged
ameliejyc merged 5 commits intomainfrom
CEUX-941-clean-up-mobile-feature-flag
Apr 15, 2026
Merged

chore: clean up pna25 feature flag#28808
ameliejyc merged 5 commits intomainfrom
CEUX-941-clean-up-mobile-feature-flag

Conversation

@ameliejyc
Copy link
Copy Markdown
Contributor

@ameliejyc ameliejyc commented Apr 14, 2026

Description

We no longer need the feature flag extensionUxPna25 which controlled the launch of the PNA25 toast message feature. This PR removes the feature flag code.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-941

Manual testing steps

There is no change to the existing UX as now the feature is on by default. Some quick things that can be checked easily are:

  • Verify onboarding metametrics string is correct:
image
  • Verify PNA25 toast does not show for newly onboarded users
  • Verify transaction_hash is included for PNA25 approved user transaction events

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes privacy/metrics gating logic by removing the extensionUxPna25 feature flag checks, which can affect when PNA25 acknowledgement is recorded and when transaction hashes are included in metrics.

Overview
Removes the extensionUxPna25 remote feature flag and all related selector/registry/mock code, simplifying PNA25 behavior to rely only on isPna25Acknowledged.

Updates onboarding and settings flows to always mark PNA25 as acknowledged on onboarding and when enabling MetaMetrics (if not already acknowledged), and updates metrics gating so ProfileMetricsController opt-in and transaction transaction_hash metrics depend solely on acknowledgement (no flag).

Refreshes copy and translations for the basic usage description, deletes flag-conditional UI rendering tests, and updates snapshots/smoke tests accordingly.

Reviewed by Cursor Bugbot for commit 02f00ae. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-extension-ux Core Extension UX team label Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
11 value mismatches detected (expected — fixture represents an existing user).
View details

@ameliejyc ameliejyc marked this pull request as ready for review April 15, 2026 08:07
@ameliejyc ameliejyc requested review from a team as code owners April 15, 2026 08:07
Copy link
Copy Markdown
Contributor

@vinistevam vinistevam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirmation

@ameliejyc ameliejyc enabled auto-merge April 15, 2026 10:30
@ameliejyc ameliejyc added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit 7512e66 Apr 15, 2026
218 of 223 checks passed
@ameliejyc ameliejyc deleted the CEUX-941-clean-up-mobile-feature-flag branch April 15, 2026 13:14
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2026
@metamaskbot metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.74.0 Issue or pull request that will be included in release 7.74.0 size-L team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants