chore: final tokensChainsCache cleanup

[juanmigdr]

Description

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3058

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Touches transaction labeling and smart-contract detection logic; while mostly cleanup, it could change UI strings and increase reliance on RPC getCode calls if any callers previously benefited from the cache shortcut.

Overview
Completes the tokensChainsCache deprecation by deleting selectors/tokenListController.ts and stripping TokenListController.tokensChainsCache from mocks, fixtures, Sentry allowlists, and snapshot expectations.

Updates asset/transaction code paths to stop reading token metadata from the token-list cache: selectAsset now sources aggregators from TokensController.allTokens, decodeConfirmTx no longer prefixes actionKey with a cached token symbol, and isSmartContractAddress removes the mainnet “in cache” fast-path so contract detection always checks on-chain code. Related tests are adjusted accordingly.

^{Reviewed by Cursor Bugbot for commit c4c505c. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit c61ce58. Configure here.}

[cursor]

Unused chainId variable after tokensChainsCache removal

Low Severity

The const chainId = txChainId assignment is now dead code. It was previously used only for the tokensChainsCache lookup that was removed in this cleanup. The variable is assigned but never read in this function scope (txChainId is referenced directly at line 884 for transactionDetails).

 

^{Reviewed by Cursor Bugbot for commit c61ce58. Configure here.}

[github-actions]

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

[sonarqubecloud]

Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details