Prevent calling messenger actions in controller/service constructors

[mcmire]

Explanation

Some controllers or services call actions from other controllers or services in the constructor (e.g. to populate local or persisted state). But this practice is not recommended, as it forces clients to use a specific order when instantiating controllers and services.

This commit updates the controller guidelines to advise against this practice and adds a lint rule to prevent it from appearing again.

References

No ticket, but I discovered while going through PerpsController that RemoteFeatureFlagController:getState is being called in the constructor.

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

Note

Medium Risk
Adds a new monorepo-wide lint restriction on this.messenger.call(...) inside constructors, which can create new lint failures across many packages and require code refactors to comply. Runtime behavior is unchanged aside from enforcing a new initialization pattern via documentation and linting.

Overview
Updates controller guidelines to prohibit calling this.messenger.call(...) inside constructors, recommending deferring such work to an init() method to avoid forcing controller/service instantiation order.

Adds a new no-restricted-syntax ESLint selector applied across packages/*/src/**/*.ts (excluding tests) to enforce this rule, and extends the existing index-file export restrictions to include the same constructor check. Updates eslint-suppressions.json with new no-restricted-syntax suppressions for current violations.

^{Written by Cursor Bugbot for commit db22c65. This will update automatically on new commits. Configure here.}

[mcmire]

I believe that the no-restricted-syntax rule in @metamask/eslint-config-typescript overrides the rule in @metamask/eslint-config. We are effectively adding back the rule from @metamask/eslint-config in this commit. So a lot of these changes don't have anything to do with the new lint rule but are merely a side effect of using this collectExistingRuleOptions function I added in a previous PR.

Most of the violations of no-restricted-syntax are The "in" operator is not allowed. Here are all of the violations of the new lint rule:

core/packages/assets-controller/src/AssetsController.ts
   743:44  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax

core/packages/assets-controller/src/data-sources/RpcDataSource.ts
  262:23  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax
  274:16  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax

core/packages/assets-controllers/src/AccountTrackerController.ts
  344:28  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax

core/packages/assets-controllers/src/MultichainAssetsRatesController/MultichainAssetsRatesController.ts
  244:51  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax

core/packages/assets-controllers/src/NftController.ts
   415:31  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax

core/packages/assets-controllers/src/TokenBalancesController.ts
  405:7   error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax
  410:28  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax

core/packages/assets-controllers/src/TokenDetectionController.ts
  282:35  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax
  288:61  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax
  297:28  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax

core/packages/core-backend/src/AccountActivityService.ts
  246:5  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax

core/packages/gas-fee-controller/src/GasFeeController.ts
  417:43  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax
  420:29  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax

core/packages/perps-controller/src/PerpsController.ts
  909:45  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax

core/packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts
  307:13  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax
  312:26  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax

core/packages/selected-network-controller/src/SelectedNetworkController.ts
  156:5   error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax
  162:11  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax
  178:17  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax

core/packages/transaction-controller/src/TransactionController.ts
   982:14  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax
   991:16  error  Do not call messenger actions in the constructor, as this forces clients to instantiate controllers or services in a specific order. Move this call to an init() method instead. Read the controller guidelines for more: ..  no-restricted-syntax

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}