feat: Multi-Telegram-channel deployments with per-channel token env convention#1757
Conversation
- Add multi-channel support to onboard wizard with role-based naming - Implement TELEGRAM_<ROLE>_BOT_TOKEN environment variable convention - Add doctor validation for duplicate token usage and naming conventions - Create YAML generation for multiple channels per platform with agent routing - Add documentation and example for Hermes-style multi-bot workforces This enables operators to run multiple Telegram bots (e.g. @company_cfo_bot, @company_ops_bot) each routing to different agents with specialized knowledge, matching Hermes workforce deployment patterns. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: praisonai-triage-agent[bot] <praisonai-triage-agent[bot]@users.noreply.github.com>
|
@coderabbitai review |
|
/review |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
✅ Actions performedReview triggered.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR adds comprehensive multi-channel bot support to PraisonAI's onboard wizard. The onboarding flow now collects multiple channels per platform, generates multi-channel YAML with role-based routing, validates token configuration via doctor checks, and includes a complete deployment guide with Hermes-style workforce examples. ChangesMulti-channel bot deployment and validation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@copilot Do a thorough review of this PR. Read ALL existing reviewer comments above from Qodo, Coderabbit, and Gemini first — incorporate their findings. Review areas:
|
Greptile SummaryThis PR adds multi-channel Telegram bot support to the onboarding wizard and doctor command, enabling role-based deployments (e.g.
Confidence Score: 3/5The onboard wizard re-prompts for platform-wide env vars once per channel rather than once per platform; input on the second or later prompt silently overwrites the shared allowlist for all channels on that platform. The main wizard flow is now reachable and YAML generation works correctly. However _configure_tokens iterates every channel and re-prompts for shared env vars like TELEGRAM_ALLOWED_USERS on every iteration, so a user setting up three Telegram roles sees the allowlist prompt three times and any mistaken entry on the second or third prompt silently replaces the global allowlist with no warning. src/praisonai/praisonai/cli/features/onboard.py, specifically the _configure_tokens method and its handling of platform-level env vars across multiple channels of the same platform. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[praisonai onboard] --> B[Step 1 Choose first platform]
B --> C{Platform valid?}
C -- No --> Z1[Abort]
C -- Yes --> D[configure_channel first]
D --> E{Add another channel?}
E -- No --> F[Step 2 configure_tokens]
E -- Yes --> G[Prompt platform and role]
G --> H[configure_channel additional]
H --> E
F --> F1[Prompt token per channel]
F1 --> F2[Prompt extra env vars per channel]
F2 --> F3[Prompt allowed users per channel]
F3 --> I[save env vars to .env]
I --> J[Step 3 Test connections]
J --> K[Step 4 Agent defaults]
K --> L[Step 5 Generate YAML]
L --> M[Step 6 Daemon install]
M --> N[Done]
Reviews (2): Last reviewed commit: "fix: critical structural regression in o..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@examples/yaml/MULTI_CHANNEL_GUIDE.md`:
- Around line 48-58: The fenced code block starting with ``` in
MULTI_CHANNEL_GUIDE.md lacks a language specifier which triggers markdownlint
MD040; update that block to use a language tag (e.g., change the opening fence
from ``` to ```text) so the block is explicitly marked as plain text and the
lint rule passes.
In `@src/praisonai/praisonai/cli/features/doctor/checks/bot_checks.py`:
- Around line 255-257: The duplicate-check logic currently groups by env var
name (channel_tokens) and misses cases where different env vars contain the same
bot token; change both checks that inspect channel_tokens (the loop using "for
env_var, channels in channel_tokens.items():") and the similar block around
lines 275-279 to resolve the actual token value (e.g., token_value =
os.environ.get(env_var) or use the existing env-resolver helper) and build a
mapping token_value -> list of channels (token_to_channels); then flag
duplicates when len(token_to_channels[token_value]) > 1 by appending to errors
(instead of checking env_var collisions), making sure to handle missing/None
values gracefully.
In `@src/praisonai/praisonai/cli/features/onboard.py`:
- Around line 641-645: The method returns prematurely after collecting channels
causing Steps 2–6 to never run and leaving Prompt undefined; remove or move the
early "return env_to_save" so that the flow continues and call
self._configure_tokens(console, Prompt) (and subsequent steps) before returning,
ensuring the variables like Prompt and env_to_save are defined in scope and that
the code from the call to self._configure_tokens through the end of the
onboarding sequence is correctly indented inside the run() method.
- Around line 465-477: The code currently allows duplicate channel keys and uses
raw role text in env names; update the onboarding flow around the role variable
and channel_key generation so that role is sanitized (e.g., strip, lower,
replace non-alphanumeric characters with underscores, collapse multiple
underscores) before being used to build env names, and check for existing keys
in self.channels to avoid silent overwrites by appending a numeric suffix
(increment until unique) or rejecting duplicates; modify the logic around role,
channel_key and wherever env vars are derived from role (the role variable,
channel_key, and env-name construction sites) to use the sanitized role and
unique-channel-key strategy.
- Around line 368-371: The class removed the attribute self.tokens but
legacy/fallback code paths in _probe and _run_plain still read/write it, which
can cause AttributeError; restore backward compatibility by reintroducing
self.tokens in __init__ (e.g., self.tokens: Dict[str, str] = {}), and ensure any
places that set/read tokens (in _probe, _run_plain) use this attribute
consistently (or migrate them to use self.channels if you prefer, but keep
self.tokens present to avoid breaking legacy paths).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ccd22bc5-ebba-4da4-b000-fea7b126794b
📒 Files selected for processing (4)
examples/yaml/MULTI_CHANNEL_GUIDE.mdexamples/yaml/multi-telegram-hermes-workforce.yamlsrc/praisonai/praisonai/cli/features/doctor/checks/bot_checks.pysrc/praisonai/praisonai/cli/features/onboard.py
| ``` | ||
| /newbot | ||
| Bot name: Company CFO Bot | ||
| Username: @company_cfo_bot | ||
| -> Copy token | ||
|
|
||
| /newbot | ||
| Bot name: Company Ops Bot | ||
| Username: @company_ops_bot | ||
| -> Copy token | ||
| ``` |
There was a problem hiding this comment.
Add a language to the fenced code block.
Line 48 opens a fenced block without a language, which will fail markdownlint MD040 in strict docs pipelines.
Suggested fix
- ```
+ ```text
/newbot
Bot name: Company CFO Bot
Username: `@company_cfo_bot`
-> Copy token
/newbot
Bot name: Company Ops Bot
Username: `@company_ops_bot`
-> Copy token
```🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 48-48: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@examples/yaml/MULTI_CHANNEL_GUIDE.md` around lines 48 - 58, The fenced code
block starting with ``` in MULTI_CHANNEL_GUIDE.md lacks a language specifier
which triggers markdownlint MD040; update that block to use a language tag
(e.g., change the opening fence from ``` to ```text) so the block is explicitly
marked as plain text and the lint rule passes.
| for env_var, channels in channel_tokens.items(): | ||
| if len(channels) > 1: | ||
| errors.append(f"Token {env_var} is used by multiple channels: {', '.join(channels)}") |
There was a problem hiding this comment.
Detect duplicates by resolved token value, not only env-var name.
On Line 255 and Line 275, duplicate detection only catches reused env var references. It misses the case where different env vars contain the same bot token (real duplicate bot usage), so this can incorrectly pass.
Suggested fix
@@
- # Check for duplicate token usage
+ # Check for duplicate token usage by env var reference
for env_var, channels in channel_tokens.items():
if len(channels) > 1:
errors.append(f"Token {env_var} is used by multiple channels: {', '.join(channels)}")
+
+ # Also check duplicate token usage by resolved token value
+ token_value_to_channels = {} # token_value -> [channel_keys]
+ for env_var, channels in channel_tokens.items():
+ token_value = os.environ.get(env_var)
+ if token_value:
+ token_value_to_channels.setdefault(token_value, []).extend(channels)
+
+ for _, channels in token_value_to_channels.items():
+ unique_channels = sorted(set(channels))
+ if len(unique_channels) > 1:
+ errors.append(
+ f"Same bot token value is used by multiple channels: {', '.join(unique_channels)}"
+ )Also applies to: 275-279
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/praisonai/praisonai/cli/features/doctor/checks/bot_checks.py` around
lines 255 - 257, The duplicate-check logic currently groups by env var name
(channel_tokens) and misses cases where different env vars contain the same bot
token; change both checks that inspect channel_tokens (the loop using "for
env_var, channels in channel_tokens.items():") and the similar block around
lines 275-279 to resolve the actual token value (e.g., token_value =
os.environ.get(env_var) or use the existing env-resolver helper) and build a
mapping token_value -> list of channels (token_to_channels); then flag
duplicates when len(token_to_channels[token_value]) > 1 by appending to errors
(instead of checking env_var collisions), making sure to handle missing/None
values gracefully.
| def __init__(self): | ||
| self.selected_platforms: List[str] = [] | ||
| self.tokens: Dict[str, str] = {} | ||
| self.channels: Dict[str, Dict] = {} # channel_key -> {platform, token, role, env_var} | ||
| self.agent_name: str = "assistant" |
There was a problem hiding this comment.
self.tokens was removed but is still used in fallback/legacy paths.
_probe (Line 827) and _run_plain (Lines 878, 885, 917) still read/write self.tokens, but __init__ no longer defines it. This can raise AttributeError in non-rich fallback and any legacy probe path.
Suggested minimal compatibility fix
class OnboardWizard:
@@
def __init__(self):
self.selected_platforms: List[str] = []
self.channels: Dict[str, Dict] = {} # channel_key -> {platform, token, role, env_var}
+ self.tokens: Dict[str, str] = {} # legacy/fallback compatibility
self.agent_name: str = "assistant"Also applies to: 824-828, 872-921
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/praisonai/praisonai/cli/features/onboard.py` around lines 368 - 371, The
class removed the attribute self.tokens but legacy/fallback code paths in _probe
and _run_plain still read/write it, which can cause AttributeError; restore
backward compatibility by reintroducing self.tokens in __init__ (e.g.,
self.tokens: Dict[str, str] = {}), and ensure any places that set/read tokens
(in _probe, _run_plain) use this attribute consistently (or migrate them to use
self.channels if you prefer, but keep self.tokens present to avoid breaking
legacy paths).
| role = _prompt_ask( | ||
| prompt_cls, | ||
| f"Role for this {info['name']} bot (e.g., 'cfo', 'ops', 'support')", | ||
| default="", | ||
| ).strip().lower() | ||
|
|
||
| if role: | ||
| channel_key = f"{platform}_{role}" | ||
| else: | ||
| # Count existing channels for this platform | ||
| existing_count = sum(1 for k in self.channels.keys() if k.startswith(f"{platform}")) | ||
| channel_key = f"{platform}_{existing_count + 1}" | ||
|
|
There was a problem hiding this comment.
Guard against duplicate channel keys and sanitize role-derived env names.
A repeated role (e.g., ops) will overwrite an existing channel silently at Line 486. Also, role text is used directly in env var construction (Line 480), so spaces/hyphens can produce invalid or non-portable env variable names.
Suggested fix
+import re
@@
- role = _prompt_ask(
+ role = _prompt_ask(
prompt_cls,
f"Role for this {info['name']} bot (e.g., 'cfo', 'ops', 'support')",
default="",
).strip().lower()
+ role = re.sub(r"[^a-z0-9_]+", "_", role).strip("_")
@@
- self.channels[channel_key] = {
+ if channel_key in self.channels:
+ console.print(f"[red]Channel '{channel_key}' already exists. Choose a different role.[/red]")
+ return
+
+ self.channels[channel_key] = {Also applies to: 479-490
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/praisonai/praisonai/cli/features/onboard.py` around lines 465 - 477, The
code currently allows duplicate channel keys and uses raw role text in env
names; update the onboarding flow around the role variable and channel_key
generation so that role is sanitized (e.g., strip, lower, replace
non-alphanumeric characters with underscores, collapse multiple underscores)
before being used to build env names, and check for existing keys in
self.channels to avoid silent overwrites by appending a numeric suffix
(increment until unique) or rejecting duplicates; modify the logic around role,
channel_key and wherever env vars are derived from role (the role variable,
channel_key, and env-name construction sites) to use the sanitized role and
unique-channel-key strategy.
| return env_to_save | ||
|
|
||
| # Step 2: Use the new token configuration method | ||
| env_to_save = self._configure_tokens(console, Prompt) | ||
|
|
There was a problem hiding this comment.
Step 2–6 flow is currently unreachable due to misplaced indentation.
After Line 641 returns from _configure_tokens, Lines 643 onward still sit in that method body, so run() effectively stops after channel collection (Step 1). This also explains the undefined Prompt at Line 644.
Also applies to: 646-817
🧰 Tools
🪛 Ruff (0.15.14)
[error] 644-644: Undefined name Prompt
(F821)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/praisonai/praisonai/cli/features/onboard.py` around lines 641 - 645, The
method returns prematurely after collecting channels causing Steps 2–6 to never
run and leaving Prompt undefined; remove or move the early "return env_to_save"
so that the flow continues and call self._configure_tokens(console, Prompt) (and
subsequent steps) before returning, ensuring the variables like Prompt and
env_to_save are defined in scope and that the code from the call to
self._configure_tokens through the end of the onboarding sequence is correctly
indented inside the run() method.
|
@claude You are the FINAL architecture reviewer. If the branch is under MervinPraison/PraisonAI (not a fork), you are able to make modifications to this branch and push directly. SCOPE: Focus ONLY on Python packages (praisonaiagents, praisonai). Do NOT modify praisonai-rust or praisonai-ts. Read ALL comments above from Gemini, Qodo, CodeRabbit, and Copilot carefully before responding. Phase 1: Review per AGENTS.md
Phase 2: FIX Valid Issues Phase 3: Final Verdict |
|
Claude finished @MervinPraison's task —— View job Final Architecture Review & Critical Fixes ✅Phase 1: Architecture Review per AGENTS.md
Phase 2: Fix Critical Issues Found by Reviewers
Phase 3: Final Verdict
✅ FINAL ARCHITECTURAL VERDICT: APPROVED WITH FIXES APPLIEDSummary of Critical Issues Fixed
Architecture Assessment per AGENTS.md✅ PASS - All changes properly follow AGENTS.md principles:
Files Modified:
Commit: ** |
…idation - Fix unreachable code in onboard wizard - Steps 2-6 were dead code after return statement - Restore self.tokens attribute for backward compatibility with legacy methods - Improve duplicate token detection to check actual token values, not just env var names - Add role sanitization (regex) and duplicate channel prevention - Fix markdown language specifier to resolve markdownlint warning Fixes structural issue where wizard would exit after Step 1 without collecting tokens, generating YAML, or installing daemon. All critical reviewer feedback addressed. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Mervin Praison <MervinPraison@users.noreply.github.com>
1 participant
Summary
Implements multi-channel Telegram bot support for Hermes-style AI workforces as requested in #1751.
Key Features
TELEGRAM_<ROLE>_BOT_TOKENChanges Made
Onboard Wizard Enhancements:
TELEGRAM_<ROLE>_BOT_TOKENpatternDoctor Validation:
multi_channel_tokenscheck validates token uniquenessYAML Generation:
praisonai bot startandpraisonai gateway startDocumentation:
Example Usage
After running
praisonai onboardand adding multiple Telegram channels:Generated
bot.yamlcreates three specialized bots:@company_cfo_bot→ routes to CFO agent@company_ops_bot→ routes to ops agent@company_content_bot→ routes to content agentTesting
Fixes #1751
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
Documentation
New Features
Examples