Skip to content

fix(stack): add descriptive message to PullRequestNotExistError#1158

Merged
mergify[bot] merged 1 commit intomainfrom
devs/jd/fix/small-stack-fixes/I323a76fa02f2fad6e08ce021d5c5f97aed13f573
Apr 15, 2026
Merged

fix(stack): add descriptive message to PullRequestNotExistError#1158
mergify[bot] merged 1 commit intomainfrom
devs/jd/fix/small-stack-fixes/I323a76fa02f2fad6e08ce021d5c5f97aed13f573

Conversation

@jd
Copy link
Copy Markdown
Member

@jd jd commented Apr 14, 2026

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Change-Id: I323a76fa02f2fad6e08ce021d5c5f97aed13f573
Copilot AI review requested due to automatic review settings April 14, 2026 20:21
@mergify mergify bot deployed to Mergify Merge Protections April 14, 2026 20:21 Active
@jd
Copy link
Copy Markdown
Member Author

jd commented Apr 14, 2026

This pull request is part of a stack:

  1. fix(stack): add descriptive message to PullRequestNotExistError (#1158) 👈
  2. fix(stack): close backtick in branch target error message (#1159)
  3. fix(stack): use asyncio.gather instead of asyncio.wait for orphan deletion (#1160)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 14, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the usability of stack change handling by providing a descriptive error message when a Change instance has no associated pull request.

Changes:

  • Add a human-readable message when raising PullRequestNotExistError from Change.pull_head_sha.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mergify mergify bot requested a review from a team April 14, 2026 20:26
@jd jd marked this pull request as ready for review April 14, 2026 20:32
@mergify mergify bot requested a review from a team April 15, 2026 05:55
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 15, 2026

Merge Queue Status

This pull request spent 5 minutes 59 seconds in the queue, including 4 minutes 48 seconds running CI.

Required conditions to merge

mergify bot added a commit that referenced this pull request Apr 15, 2026
@mergify mergify bot added the queued label Apr 15, 2026
mergify bot added a commit that referenced this pull request Apr 15, 2026
@mergify mergify bot merged commit 98ae1a8 into main Apr 15, 2026
15 checks passed
@mergify mergify bot deleted the devs/jd/fix/small-stack-fixes/I323a76fa02f2fad6e08ce021d5c5f97aed13f573 branch April 15, 2026 06:56
@mergify mergify bot removed the queued label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants