Skip to content

fix: remove redundant table borders#10634

Open
jd wants to merge 1 commit intomainfrom
devs/jd/worktree-compiled-discovering-rocket/I7b4dc1ba24e2269d9dc755fdfc82b1a9d749c407
Open

fix: remove redundant table borders#10634
jd wants to merge 1 commit intomainfrom
devs/jd/worktree-compiled-discovering-rocket/I7b4dc1ba24e2269d9dc755fdfc82b1a9d749c407

Conversation

@jd
Copy link
Member

@jd jd commented Mar 20, 2026

Remove the border on tr elements which was doubling up with the
table outer border and td/th cell borders. Replace with a rule
that removes the bottom border on the last tbody row to avoid a double
line against the table's outer border.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Copilot AI review requested due to automatic review settings March 20, 2026 15:52
@mergify mergify bot had a problem deploying to Mergify Merge Protections March 20, 2026 15:52 Failure
@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 👀 Review Requirements

This rule is failing.
  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • author = mergify-ci-bot

🔴 🔎 Reviews

This rule is failing.
  • #review-requested = 0
  • #changes-requested-reviews-by = 0
  • #review-threads-unresolved = 0

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success = build
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

@jd jd marked this pull request as ready for review March 20, 2026 15:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts global table styling to eliminate redundant/doubled borders by removing row-level borders and instead suppressing the bottom border on the final body row so it doesn’t overlap with the table’s outer border.

Changes:

  • Remove the tr { border: ... } rule that was adding an extra border per row.
  • Add a tbody tr:last-child td/th { border-bottom: none; } rule to prevent a doubled bottom line against the table border.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mergify mergify bot requested a review from a team March 20, 2026 15:54
JulianMaurin
JulianMaurin previously approved these changes Mar 20, 2026
Remove the border on `tr` elements which was doubling up with the
`table` outer border and `td`/`th` cell borders. Replace with a rule
that removes the bottom border on the last tbody row to avoid a double
line against the table's outer border.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Change-Id: I7b4dc1ba24e2269d9dc755fdfc82b1a9d749c407
Claude-Session-Id: 6780ce1e-af40-47b5-9605-9f97ff5167dc
@mergify mergify bot requested a review from a team March 20, 2026 15:55
@jd jd force-pushed the devs/jd/worktree-compiled-discovering-rocket/I7b4dc1ba24e2269d9dc755fdfc82b1a9d749c407 branch from c56e76d to 83db73c Compare March 20, 2026 15:55
@mergify mergify bot dismissed JulianMaurin’s stale review March 20, 2026 15:55

Pull request has been modified.

@mergify mergify bot had a problem deploying to Mergify Merge Protections March 20, 2026 15:55 Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants