Skip to content

add log #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarltonXiang merged 1 commit into from
Dec 17, 2025
Merged

add log #730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 10 additions & 17 deletions src/memos/graph_dbs/polardb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3349,6 +3349,7 @@ def add_nodes_batch(
- metadata: dict[str, Any] - Node metadata
user_name: Optional user name (will use config default if not provided)
"""
batch_start_time = time.time()
if not nodes:
logger.warning("[add_nodes_batch] Empty nodes list, skipping")
return
Expand Down Expand Up @@ -3517,13 +3518,6 @@ def add_nodes_batch(
%s::vector
)
"""
logger.info(
f"[add_nodes_batch] embedding_column Inserting insert_query:{insert_query}"
)
logger.info(
f"[add_nodes_batch] embedding_column Inserting data_tuples:{data_tuples}"
)

# Execute batch insert
execute_values(
cursor,
Expand Down Expand Up @@ -3572,6 +3566,10 @@ def add_nodes_batch(
logger.info(
f"[add_nodes_batch] Inserted {len(nodes_group)} nodes with embedding_column={embedding_column}"
)
elapsed_time = time.time() - batch_start_time
logger.info(
f"[add_nodes_batch] execute_values completed successfully in {elapsed_time:.2f}s"
)

except Exception as e:
logger.error(f"[add_nodes_batch] Failed to add nodes: {e}", exc_info=True)
Expand Down Expand Up @@ -4780,12 +4778,10 @@ def delete_node_by_prams(
Returns:
int: Number of nodes deleted.
"""
batch_start_time = time.time()
logger.info(
f"[delete_node_by_prams] memory_ids: {memory_ids}, file_ids: {file_ids}, filter: {filter}, writable_cube_ids: {writable_cube_ids}"
)
print(
f"[delete_node_by_prams] memory_ids: {memory_ids}, file_ids: {file_ids}, filter: {filter}, writable_cube_ids: {writable_cube_ids}"
)

# Validate writable_cube_ids
if not writable_cube_ids or len(writable_cube_ids) == 0:
Expand Down Expand Up @@ -4879,7 +4875,6 @@ def delete_node_by_prams(
$$) AS (node_count agtype)
"""
logger.info(f"[delete_node_by_prams] count_query: {count_query}")
print(f"[delete_node_by_prams] count_query: {count_query}")

# Then delete nodes
delete_query = f"""
Expand All @@ -4893,11 +4888,7 @@ def delete_node_by_prams(
logger.info(
f"[delete_node_by_prams] Deleting nodes - memory_ids: {memory_ids}, file_ids: {file_ids}, filter: {filter}"
)
print(
f"[delete_node_by_prams] Deleting nodes - memory_ids: {memory_ids}, file_ids: {file_ids}, filter: {filter}"
)
logger.info(f"[delete_node_by_prams] delete_query: {delete_query}")
print(f"[delete_node_by_prams] delete_query: {delete_query}")

conn = None
deleted_count = 0
Expand All @@ -4917,10 +4908,12 @@ def delete_node_by_prams(
cursor.execute(delete_query)
# Use the count from before deletion as the actual deleted count
deleted_count = expected_count
conn.commit()
elapsed_time = time.time() - batch_start_time
logger.info(
f"[delete_node_by_prams] execute_values completed successfully in {elapsed_time:.2f}s"
)
except Exception as e:
logger.error(f"[delete_node_by_prams] Failed to delete nodes: {e}", exc_info=True)
conn.rollback()
raise
finally:
self._return_connection(conn)
Expand Down